mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-13 03:13:58 +03:00
[Feature Request]: Support correct umlaut conversion for URL slugs #2500
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cod3monk on GitHub (Nov 22, 2021).
Describe the feature you'd like
When using umlauts in page titles umlauts are removed in URL slugs, e.g.,
öäübecomes/oau, while it should convert to (according to German conventions)/oeaeue. Also,ßshould convert intoss.Describe the benefits this feature would bring to BookStack users
Better readability of URL slugs.
Additional context
https://en.wikipedia.org/wiki/Diaeresis_(diacritic)#HTML
https://en.wikipedia.org/wiki/%C3%9F
@ssddanbrown commented on GitHub (Nov 22, 2021):
Hi @cod3monk,
On the latest version of BookStack a page name of
öäüßresults in a slug ofoauss.So looks like the
ßis converting fine.In regards to the
öäü, the linked Wikipedia page showsoauas a valid replacement for these characters.Generally I'd prefer to generally stick to the framework's handling of these characters to save us the effort, unless the current behaviour could be considered harmful in any manner.
@ssddanbrown commented on GitHub (Nov 30, 2021):
Since there's been no further discussion here I'll close this off.
@cod3monk commented on GitHub (Jul 19, 2022):
@ssddanbrown
I would not consider it technically harmful, but a matter of quality and compliance with german spelling rules. The current choice leads to misspelled slugs from currently spelled page titles.