mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
[Bug Report]: Headers nested within other elements are not assigned IDs for Page Navigation #2489
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bourdaisj on GitHub (Nov 17, 2021).
Describe the Bug
In the top left of a page where you got the "Page navigation" section, there are links with anchors to get the user to the title on click. But in my case the title have no id so the anchors link are not working (Example : https://bookstackuri.com/books/bookname/page/pagename#
Steps to Reproduce
Expected Behaviour
The element (in my case h5) should have an id when being created so that the system can generate a correct anchor link
Screenshots or Additional Context
I'm observing this bug in 21.10.03, but I believe the page was created under version 0.30 (approximately)
Exact BookStack Version
21.10.03 or +/-0.30
PHP Version
7.4
Hosting Environment
Ubuntu 20.04
EDIT : I can work on it if needed
EDIT 2 : steps to reproduce update
@ssddanbrown commented on GitHub (Nov 18, 2021):
Thanks for reporting @Julesdevops but I can't seem to reproduce this. Top level content blocks, such as these headers, should automatically be assigned unique IDs. This has long been functionality in BookStack.
@bourdaisj commented on GitHub (Nov 18, 2021):
Thanks for the rapid feedback @ssddanbrown
Our instance is using the standard WYSIWYG.
Actually I am able to reproduce this bug on the demo instance. (maybe it'll be down when you see this but anyway : https://demo.bookstackapp.com/books/bookstack-demo-site/page/testtest-test-test-test#)
It seems to happen when title are in a table...
Screenshot:
@ssddanbrown commented on GitHub (Nov 18, 2021):
@Julesdevops Thanks for the confirmation. Yeah, Can see why that would break things. We currently parse and apply ids to the top-level elements only.
Will update this issue to be specific to nested header usage.
@bourdaisj commented on GitHub (Nov 18, 2021):
I can surely provide a PR to fix this.
Do you want to simply disable navigation links for non top-level headers or fix the bug and assign IDs to the nested headers ?
@ssddanbrown commented on GitHub (Nov 18, 2021):
Thanks for offering a PR @Julesdevops. To be honest, I have no major preference but I'd probably sway towards the idea of not showing such headers in the navigation. Easier to implement (Just filter out headers without an ID) and there's probably less chance they're actually used for hierarchy in such scenarios, but if you'd find value in having them show as part of the navigation I don't mind going down that route either.
@bourdaisj commented on GitHub (Nov 19, 2021):
Tbh I don't mind either but since my customer has an interest in solution 2 I'm going that way.
@ssddanbrown commented on GitHub (Nov 23, 2021):
Fixed in #3069, To be part of next release, Will therefore close this off.