starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

Update logout endpoints to be POST (Or CSRF protected in general) #2481

New Issue
Closed
opened 2026-02-05 04:17:40 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 04:17:40 +03:00
Owner
Copy Link

Originally created by @ssddanbrown on GitHub (Nov 9, 2021).

Describe the Bug

To prevent potential targeted annoyance via CSRF.
As discussed within https://huntr.dev/bounties/114bfbc2-850a-4116-aa07-0d666a9626de/.

Notes

  • Would need to publish as part of update notes as there's a potential people are utilising this get logout endpoint.
  • Also need to review usage of the SAML one to see if that could be used as part of a SAML process.
  • Will need to update testing.
Originally created by @ssddanbrown on GitHub (Nov 9, 2021). ### Describe the Bug To prevent potential targeted annoyance via CSRF. As discussed within https://huntr.dev/bounties/114bfbc2-850a-4116-aa07-0d666a9626de/. #### Notes - Would need to publish as part of update notes as there's a potential people are utilising this get logout endpoint. - Also need to review usage of the SAML one to see if that could be used as part of a SAML process. - Will need to update testing.
OVERLORD added the 🛠️ Enhancement📖 Docs Update🔒 Security labels 2026-02-05 04:17:40 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 📖 Docs Update 🛠️ Enhancement 🔒 Security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#2481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?