mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 03:09:39 +03:00
[Bug Report]: OIDC Login #2474
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @git-noise on GitHub (Nov 1, 2021).
Describe the Bug
OIDC login leads to a blank page and a HTTP 500 query answer
Steps to Reproduce
Expected Behaviour
OIDC Login should redirect to the OIDC provider login page or log the user into Bookstack if already logged-in
Screenshots or Additional Context
Laravel logs:
Exact BookStack Version
v21.10.3 - same on v21.10.2
PHP Version
7.2
Hosting Environment
Ubuntu 18.04 LTS, Apachee2 reverse-proxy, manual installation.
@ssddanbrown commented on GitHub (Nov 1, 2021):
Hi @git-noise,
Could you open the file
/opt/bookstack/BookStack/storage/framework/views/1a15a2c52c34a48c83eaeee648b7bab225c2ed2d.phpon your instance, scroll to the bottom and find a line that contains "PATH" and "ENDPATH" then provide the show path? I just need to understand where this may be originating from.@git-noise commented on GitHub (Nov 1, 2021):
Hello and thanks for your answer.
Sure thing it is:
/opt/bookstack/BookStack/resources/views/layouts/base.blade.phpThanks,
@ssddanbrown commented on GitHub (Nov 1, 2021):
Thanks @git-noise, Not really sure why you'd be getting that error.
Could you:
git statuswithin the BookStack install folder.@git-noise commented on GitHub (Nov 2, 2021):
Here it is:
This change comes from mysql TLS config
URL path:
/oidc/loginStack trace:
Many thanks,
@ssddanbrown commented on GitHub (Nov 2, 2021):
@git-noise Thanks for providing the information but I really don't understand this one.
The
/oidc/loginendpoint should not even utilise a view which is what the system is attempting use here and erroring out upon. Additionally, the cspNonce value should be available to all web endpoint views.Does everything in a non-oidc context work without issue? So with standard authentication can you access the system and perform all common functions without issue?
@git-noise commented on GitHub (Nov 2, 2021):
@ssddanbrown
Indeed I can, either via local database or gitlab and everything works well.
Regarding OIDC case, nothing in the web console either, except for that 500 internal error to https://mydomain/oidc/login.
That being said, I am getting a 404 on that /oidc/login when I am doing a get on it. Am I redirected to the right page?
@ssddanbrown commented on GitHub (Nov 2, 2021):
404 on
GETis expected, since it's a post endpoint.Can you list any
.phpfiles that are in thebootstrap/cachedirectory within your instance?@git-noise commented on GitHub (Nov 2, 2021):
I figured, makes sense, but you never know
Yes so I have:
@git-noise commented on GitHub (Nov 3, 2021):
@ssddanbrown
Hello,
If it makes sense I'll try to redeploy things in a containerized environment and report back. If I am the only one with this error it may be linked to some legacy things from previous installation that are not playing too well. It won't be immediate, but I'll get to it when I can.
Best,
@santiago-mooser commented on GitHub (Nov 8, 2021):
I'm having the same issue, but I think it may have to do with a broken foreign key constraint in my database. I upgraded from MariaDB 10.4.x to 10.5.12 and bookstack 21.04.2 to 21.08.5 and I'm getting a 500 error when I try to sign in.
The setup I'm currently running is using docker-compose:
And I made the mistake of upgrading both containers without checking whether I needed to go through an upgrade procedure (my mistake...), so I'm in the process of figuring out what the problem is.
This is the nginx error log:
And this is the php error log (there doesn't seem to be anything unusual here):
However, I am getting some weird errors with MariaDB when I try to export it with mysqldump:
Considering that someone got a similar error when there was a piece of data that broke a foreign key contraint, I think something happened in the update from 21.04.2 to 21.08.6 that fucked a database row up and is now preventing the database from properly working.
I'll look into it a bit more and update as soon as I figure out the problem.
@santiago-mooser commented on GitHub (Nov 8, 2021):
So, it seems that there is some type of corruption or attribute break in the
activitiestable. I was able to figure out by manually dumping all the different tables.I got the full table list:
Then wrote up a really dirty mysqldump script:
This would crash my database(?) which would then refuse to do anything:
From here, I simply removed the
activitiestable from the dump script:And was able to successfully extract all other tables:
Conclusion
Something in the upgrade process of either the database or bookstack corrupted or changed the values in the
activitiestable to the point where not even the DBMS is able to open the table correctly. I'll have to see whether I'm able to re-import the information without theactivitiestable into a new bookstack instance.I have no idea what happened but I'll update you guys as I figure it out 🤷🏼
@git-noise commented on GitHub (Nov 8, 2021):
Interesting @santiago-mooser. I am not using mariadb and do not have any DB issues afaik, but that maybe points to some upgrade silently gone wrong then.
@ssddanbrown commented on GitHub (Apr 25, 2022):
Since there's been no recent activity here I'm going to close this. If the issue remains and is something you still require to be fixed respond to my comment with the current status and this can then be re-opened.