mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 11:19:38 +03:00
Error 500 when opening the gallery #2385
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @awesome-michael on GitHub (Sep 10, 2021).
Describe the bug
When I try to insert an image on a page I get an error 500 from the server
Steps To Reproduce
Steps to reproduce the behavior:
GET https://example.com/images/gallery?page=1&uploaded_to=142 500in the browser consoleExpected behavior
Gallery shows images that were uploaded
Screenshots
If applicable, add screenshots to help explain your problem.
Your Configuration (please complete the following information):
Additional context
I tried to debug the error but can't find anything related in the error logs at storage/logs/laravel.log and even setting the APP_DEBUG=true in the .env file didn't reveal any information on the error (I think the setting didn't change anything at all).
@ssddanbrown commented on GitHub (Sep 12, 2021):
Hi @awesome-michael,
@awesome-michael commented on GitHub (Sep 12, 2021):
Hi @ssddanbrown,
@ssddanbrown commented on GitHub (Sep 13, 2021):
@awesome-michael Something to try below. I suspect this is either due to query parameters not being passed as expected (Can occur when there's a slight proxy/webserver misconfiguration) or a particular image is causing trouble when a thumbnail is attempting to be generated.
https://example.com/images/gallery?page=1&uploaded_to=142URL directly (But on your instance)? Just want to understand the level at which this is generated, hoping the error screen can provide some clues.@awesome-michael commented on GitHub (Sep 17, 2021):
@ssddanbrown commented on GitHub (Sep 18, 2021):
Hi @awesome-michael,
This is not an error being handled at a BookStack level, but more likely at a webserver level. You'll need to check your webserver's error logs. Since you're using a docker setup keep in mind that you'll likely have mulitple web-servers at play (One inside and one outside the container).
@ssddanbrown commented on GitHub (Sep 29, 2021):
Since there's been no follow-up I'm going to close this. If the issue remains and is something you still require to be fixed please open a new issue, referencing this one.
@badsmoke commented on GitHub (Aug 21, 2023):
we now have the same problem
this error message appears in the console
browser console log:
but it has definitely worked before.
bookstack runs behind an nginx and a subdir
thank you
@al-cheb commented on GitHub (Aug 22, 2023):
@ssddanbrown, @badsmoke
In my case I have uploaded a high resolution png(16000x16000) file ~ 8mb and after that I got the 500 error.
Steps to reproduce:
I know this case is very rare but it's difficult to debug such kind behavior and easy to block the Image Selector .
@ssddanbrown commented on GitHub (Aug 22, 2023):
Yeah, large images can lead to memory being exhausted when attempting to resize.
Maybe we should force fail upon upload in these scenarios with applicable warning, will have to test how easy it is to catch since it's an out-of-memory situation.
@al-cheb commented on GitHub (Aug 22, 2023):
Yeah, it would be great if we have a warning on upload and replace a preview icon if a file can't be properly displayed to make it easy to find .
@ssddanbrown commented on GitHub (Aug 22, 2023):
@al-cheb I'd probably just prevent the upload entirely (with a better warning/error message) if it can't be resized, rather than add control to set a custom preview icon. We also resize to make the image used within content reasonable. I don't want to end up where users can easily upload and use massive multi-MB in content. Can always resort to attachments instead if a massive image really does need to be uploaded.
@ssddanbrown commented on GitHub (Aug 22, 2023):
I've opened up #4454 as an intent to improve things as discussed above, which is assigned to a future maintenance release.
@badsmoke commented on GitHub (Aug 22, 2023):
you guys are great, I write just before going to sleep and when I wake up you have already taken care of it :-D
i just checked, the files are all about 2.7mb in size, when i delete them the gallery loads again.
when uploading again, comes the error
POST https://wiki.domain.com/images/gallery?uploaded_to=474 500I also see no cpu or ram load when uploading
@ssddanbrown commented on GitHub (Aug 22, 2023):
@badsmoke
It's probably hard to observe since the default PHP RAM limit is often small and this will only spike for a very quick moment.
The PHP option
memory_limitdefaults to 128MB in most cases, increasing this option (usually via a relevantphp.inifile) can help handle much larger images.@badsmoke commented on GitHub (Aug 28, 2023):
thank you, a increasing has solved the problem