mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Markdown blockquotes not rendering correctly in preview #2336
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @techauthoruk on GitHub (Jul 28, 2021).
Describe the bug
When using the Markdown editor and adding a blockquote, the blockquote does not render correctly in the preview pane
Steps To Reproduce
Steps to reproduce the behavior:
> Whatever text you likeExpected behavior
The blockquote should render correctly in the preview pane
Screenshots
Source:
Preview:
Page:
Your Configuration (please complete the following information):
Additional context
This behaviour shows on existing as well as new pages
@techauthoruk commented on GitHub (Aug 5, 2021):
Mmmm, still puzzling me, this one. I know it doesn't actually impact on what you are trying to create (as the page displays correctly) but it would be nice to see the content correctly in the preview pane before you commit the changes. On a similar vein, I noticed that code blocls are actually highlighted/have colour in the editor pane, not in the preview pane, but display correctly on the published page!
@ssddanbrown Dan - is this an issue with CodeMirror or is there something else at play here? I know it is a really niggly thing that doesn't impact on the page itself, but it would be nice to see the prieview as it should be before its published. Maybe this is caused by the same issue that affects blockquotes #2858 - @ssddanbrown any thoughts Dan?
@ssddanbrown commented on GitHub (Aug 5, 2021):
@techauthoruk The blockquote issue probably is an issue (I can kind guess it's a specific styling issue) but just have not yet spent the time to investigate.
The codeblocks are a known thing, We don't render them out via CodeMirror in the markdown preview for performance (The preview pane is re-rendered on each markdown input change). We could implement a more advanced way to update that preview so we wouldn't have to re-render CodeMirror blocks each change, but I'll be looking into changing the editors significantly later this year so there's not much point spending time on the existing editors unless it's fundamental bugs being addressed.
@ssddanbrown commented on GitHub (Aug 22, 2021):
Thanks once again for reporting @techauthoruk.
This has now been addressed and will be part of the next feature release.