mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-13 03:13:58 +03:00
Separate English into UK/US #2273
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vMotionFailed on GitHub (Jun 1, 2021).
Describe the feature you'd like
I think it would be helpful if there was a lang option for en_US and en_UK. So far the only spelling difference I've noticed is favourite, spelled favorite in US. But I would imagine as the platform continues to add new features there'll probably be a lot more instances of this.
Describe the benefits this feature would bring to BookStack users
Users in the US wouldn't have to create themes and manually translate UK to US spelling.
Additional context
Also, favorites could have totally been called Bookmarks. BookStack, bookmarks, seems like a match made in heaven :D
Thanks for making Bookstack, definitely a big fan of the platform.
@vMotionFailed commented on GitHub (Jun 1, 2021):
Actually, just noticed that even if I wanted to create a custom theme and create a translation via the Hacking BookStack documentation, it doesn't actually change it everywhere as it appears to be hardcoded in some areas.
@ssddanbrown commented on GitHub (Jun 1, 2021):
Hi @escservices,
There's also color vs colour, Currently using the US spelling there. We can split these out I suppose, didn't really feel like we'd need to but if you feel passionately enough to attempt using theme overrides instead then I guess it's maybe time.
Yeah, This was discussed in #2063, Works well with the theme but too much room for confusion since it's commonly used by browsers.
That should not be the case, but I totally could have left some text hardcoded. The only places that I can think of that would be hardcoded are the URL terms and text within the WYSIWYG editor. The API documentation is also EN only for now. If you've found bits outside of that feel free to raise them to be made translatable.
@vMotionFailed commented on GitHub (Jun 2, 2021):
Thanks @ssddanbrown for the quick reply! That makes sense.
That's a good one too, it's not too visible though, I believe I've only seen colors on the settings pages, maybe it's in WYSIWYG editor and I missed it. With the favourite/unfavourite on almost every page I think a few of my users will point it out and ask me to change it (currently just over 100 users at the company). It's funny how something so simple sticks out so much when you're not used to the different spelling.
If the theme override method covered more of the UI, then it would probably be fine to delay splitting them for awhile until there are more instances of language differences in the end user parts of the UI.
The only areas I've noticed that weren't affected by the theme translation was the top left section on the homepage "My Most Viewed Favourites" and under the user dropdown "My Favourites". And the url path as you've mentioned. I'm guessing the URL paths probably can't be changed, but maybe those links could be?
Thanks again!
@ssddanbrown commented on GitHub (Jun 2, 2021):
@escservices Those strings should be overridable via theme system, although they are in a different file compared to "Favourite/Unfavourite":
fdabafffda/resources/lang/en/entities.php (L30-L31)Yeah, Won't be able to change the spelling in URL though.
@vMotionFailed commented on GitHub (Jun 2, 2021):
@ssddanbrown It worked! Thanks for the help, I really appreciate it!