mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 16:49:47 +03:00
Deleting a book does not delete corresponding table records #2218
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tstkenny on GitHub (Apr 24, 2021).
I am developing a store procedure to save an existing book into a new book including chapters and pages and I found a related bug:
When you delete a book via UI, some of the relational table records are not deleted. e.g. joint_permission.
If you use the UI button to copy all the permissions in a BookShelf to all Books, the deleted books will APPEAR AGAIN, which is a serious bug.
A quick but dirty fix:
delete from books where deleted_at is not null;
delete from chapters where deleted_at is not null;
delete from pages where deleted_at is not null;
delete from joint_permissions where entity_type='BookStack\Page' AND entity_id not in (select id from pages);
delete from joint_permissions where entity_type='BookStack\Chapter' AND entity_id not in (select id from chapters);
delete from joint_permissions where entity_type='BookStack\Book' AND entity_id not in (select id from books);
Thank you.
@ssddanbrown commented on GitHub (Apr 27, 2021):
Thanks for reporting @tstkenny,
Just to confirm, When you say "the deleted books will APPEAR AGAIN", do you mean within the user interface or do you mean within the database?
@tstkenny commented on GitHub (May 1, 2021):
@ssddanbrown actually the record never got deleted so it stays in the database since beginning. The book will re-appear in the UI.
@ssddanbrown commented on GitHub (May 1, 2021):
Hi @tstkenny,
I just attempted to re-produce this by doing the following:
After doing this the book did not re-appear but remained deleted, in the recycle bin, as expected and therefore did not re-appear in the shelf within the UI. I tested the and without custom permissions set on the shelf.
Does you instance behave differently? If so please can you confirm the version?
@ssddanbrown commented on GitHub (May 24, 2021):
Since there's been no follow-up I'm going to close this. If the issue remains and is something you still require to be fixed please open a new issue, referencing this one.