mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Restore from recycle bin failed #2165
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dusatvoj on GitHub (Mar 18, 2021).
Describe the bug
Somebody deleted a page. I've tried to restore it (Recycle bin -> restore). Now: page isn't in recycle bin even restored (can't find that page)
Steps To Reproduce
Steps to reproduce the behavior:
Successfully restored pages: 0Expected behavior
Successfully resotred page with link in clipboard / smth like this.
Screenshots
N/A
Your Configuration (please complete the following information):
0.31.2(after that upgraded tolatest)v7.4.13mod_phpAdditional context
Add any other context about the problem here.
@ssddanbrown commented on GitHub (Mar 19, 2021):
Hi @dusatvoj,
There are some edge cases that can cause issues that we've fixed in more recent patch releases. I'm not sure what the
latestin your issue refers to, but it's worth updating tov0.31.8to help prevent these.It may be the case you hit an issue that prevented the permissions for the page being built correctly.
You could attempt to regenerate these, after updating, by using the
php artisan bookstack:regenerate-permissionscommand: https://www.bookstackapp.com/docs/admin/commands/#regenerate-access-permissions@dusatvoj commented on GitHub (Mar 19, 2021):
Hi @ssddanbrown ,
Yep, I mean latest release ... it's
0.31.8. I've tried to regenerate permissionsphp artisan bookstack:regenerate-permissionsbut the page looks lost. Maybe it's caused by some bug inv0.31.2(the version I've tried to restore page). There's in DB stilldeleted_atdate. Is that correct? (Maybe there's just something stuck in DB ... IDK)@ssddanbrown commented on GitHub (Mar 19, 2021):
Hmm, No, That's not correct if it's been restored.
Setting the
deleted_atdate tonullshould make it re-appear.@ssddanbrown commented on GitHub (Mar 19, 2021):
@dusatvoj As an extra note, is the parent book/chapter definitely not also in the recycle bin? That could also cause this behavior.
@dusatvoj commented on GitHub (Mar 19, 2021):
I've set page's
deleted_attonulland it's restored now.Yes, It was our fault. Our co-workers told me that they deleted a page but they deleted a whole book. I've tried restore a page and bookstack told me
success: 0and page dissappeared from trash but not restored.Is there a possibility (if it's not done yet in
v0.31.8) to leave page in trash if restore wasn't success? This was confusing 😊@ssddanbrown commented on GitHub (Mar 19, 2021):
Thanks for confirming @dusatvoj.
These edge-case scenarios get tricky. The page has been restored itself but the delete is still inferred by the parent. I'm pretty sure I handled this by showing a message when you attempt to restore an item in such a scenario:
@dusatvoj commented on GitHub (Mar 19, 2021):
Oh, I've missed the message under restore button.
Thank you for your time.
@ssddanbrown commented on GitHub (Mar 19, 2021):
No problem! I'll keep this in mind though, If we start to see many other similar reports I'll look to tweak the user experience/feedback to make these more obvious.