Perform a review pass of the permission service #2153

New Issue

OVERLORD · 2026-02-05T03:07:32+03:00

OVERLORD commented

2026-02-05 03:07:32 +03:00

Originally created by @ssddanbrown on GitHub (Mar 12, 2021).

Originally assigned to: @ssddanbrown on GitHub.

More of a reminder for me:

Review the permission service class.

Move phpdoc to types.
Remove instances if ->isA()
entityCache['chapter'] ~~does not appear to be actually used.~~ It does appear to use it but does potentially overly wipe it when processing many items, May not matter depending on entries to readyEntityCache

Originally created by @ssddanbrown on GitHub (Mar 12, 2021). Originally assigned to: @ssddanbrown on GitHub. More of a reminder for me: Review the permission service class. - [x] Move phpdoc to types. - [x] Remove instances if `->isA()` - [x] `entityCache['chapter']` ~~does not appear to be actually used.~~ It does appear to use it but does potentially overly wipe it when processing many items, May not matter depending on entries to `readyEntityCache`

OVERLORD added the 🔧 Maintenance 🏭 Back-End labels 2026-02-05 03:07:32 +03:00

OVERLORD closed this issue

2026-02-05 03:07:34 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#2153