mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 11:19:38 +03:00
Include the app logo in emails sent by BookStack #2111
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @digitall-it on GitHub (Feb 21, 2021).
Describe the feature you'd like
Our site header has my logo and the word "docs" after it. However, on sending a password init email, only the word "docs" appears, without the logo, so the user isn't sure it comes from me. I suggest separating the site and the email headers in two different fields in the
/settingsform in the customization section.Describe the benefits this feature would bring to BookStack users
Better recognition of BookStack legit emails.
Additional context
Attached a screenshot of a test email.
@ssddanbrown commented on GitHub (Feb 26, 2021):
Thanks for the request @digitall-it.
I'd prefer not to have additional settings simply to account for an edge-case scenario if possible.
Would you feel that the core issue would be solved here if we added the logo image into the header of the emails sent by the platform, alongside the text as per the web interface header?
@digitall-it commented on GitHub (Feb 26, 2021):
That would be even better, but it is important to have alt text on the image if it is not base 64 encoded in the message.
@ssddanbrown commented on GitHub (Feb 26, 2021):
@digitall-it Thanks for confirming. I'll therefore update the issue title to focus on the above mentioned alternative.
@ssddanbrown commented on GitHub (May 26, 2021):
Patch applied for this now, Will be part of the next feature release.
@ssddanbrown commented on GitHub (May 26, 2021):
Hi @digitall-it,
After further thinking and reviewing of the options I've just reverted the inclusion of this.
This would be adding an additional bit of complexity to emails which would likely raise more issues, and you requested this having good alt text which would not currently be possible without another input, which this solution was attempting to avoid.
We use the app name in a few places, Even with this added there'd still be oddities in your setup due to this combination of app name and logo.
Next to the name input within the setttings there's a "Show name in header" checkbox. Quite honestly I think your situation would work best, and this would be solved, if you included the "docs" text within your app logo image. That way you can make the full name descriptive and readable for emails and other potential locations.