mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 19:06:05 +03:00
Don't scale down the application logo #2109
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @abulgatz on GitHub (Feb 19, 2021).
Currently the application logo gets scaled down to 43px in height.
This doesn't look very good on a High DPI screen (above 100% scaling on Windows, most modern Macs, smart phones, etc.).
I'm not sure the scaling is necessary at all, but if we want to keep the scaling, 2x (86px) is probably a better height to scale to.
@ssddanbrown commented on GitHub (Feb 20, 2021):
Thanks for raising @abulgatz,
I'd want to keep the scaling but agree, we should double it up for HighDPI.
@Hecke29 commented on GitHub (Mar 5, 2021):
Current code already contains
86pxfor height-scaling (and does so since 2 years):5e01c30882/app/Http/Controllers/SettingController.php (L61)Should it be doubled to
172or is this task stale?@abulgatz commented on GitHub (Mar 5, 2021):
Actually, when I just tried uploading a logo, it didn't scale at all with my current latest Bookstack install, so I'm not sure what's going on?
@ssddanbrown commented on GitHub (Mar 6, 2021):
@Hecke29 Thanks for checking, I'd say double should be enough.
@abulgatz Just tested it against the latest version and the logo got scaled to 86px. Is your uploaded image at least 86px in height or have you made any modifications to the code of your instance?
@ssddanbrown commented on GitHub (Apr 19, 2021):
Since there's been no follow-up I'm going to close this. If the issue remains and is something you still require to be fixed please open a new issue, referencing this one.