starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-05-04 18:08:46 +03:00
Code Issues 784 Packages Projects Releases 15 Wiki Activity

After login via SAML, Bookstack redirects to home page instead of original URL #2091

New Issue
Closed
opened 2026-02-05 02:52:03 +03:00 by OVERLORD · 10 comments
OVERLORD commented 2026-02-05 02:52:03 +03:00
Owner
Copy Link

Originally created by @tmrhymer on GitHub (Feb 11, 2021).

Describe the bug
We recently implemented SAML/SSO for our Bookstack environment and authentication works great except for one issue. If an unauthenticated user tries to navigate directly to an inner Bookstack page, they get redirected to the login page. They click Login With SSO. After authenticating, they are redirected to our Bookstack home page instead of the originally requested URL. Users than have to go back click/type in their original URL.

Steps To Reproduce
In an environment using SAML/SSO for authentication:

  1. Go to an inner page that requires authentication
  2. Click Login with SSO
  3. You get redirected to the home page instead of the originally requested inner page.

Expected behavior
We would expect to be redirected to the originally requested page after authenticating with SAML/SSO

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): 31.4
  • PHP Version: PHP 7.3.26
  • Hosting Method (Nginx/Apache/Docker): Apache 2.4.6

Additional context
IDP is Azure AD

2021-02-11 17_33_49-Microsoft Azure

SAML2_NAME=SSO
SAML2_EMAIL_ATTRIBUTE=http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress
SAML2_EXTERNAL_ID_ATTRIBUTE=uid
SAML2_DISPLAY_NAME_ATTRIBUTES=http://schemas.microsoft.com/identity/claims/displayname
SAML2_IDP_ENTITYID=https://sts.windows.net/<redacted>/
SAML2_AUTOLOAD_METADATA=false
SAML2_IDP_SSO=https://login.microsoftonline.com/<redacted>/saml2
SAML2_IDP_SLO=https://login.microsoftonline.com/common/wsfederation?wa=wsignout1.0
SAML2_IDP_x509=<redacted>
Originally created by @tmrhymer on GitHub (Feb 11, 2021). **Describe the bug** We recently implemented SAML/SSO for our Bookstack environment and authentication works great except for one issue. If an unauthenticated user tries to navigate directly to an inner Bookstack page, they get redirected to the login page. They click Login With SSO. After authenticating, they are redirected to our Bookstack home page instead of the originally requested URL. Users than have to go back click/type in their original URL. **Steps To Reproduce** In an environment using SAML/SSO for authentication: 1. Go to an inner page that requires authentication 2. Click Login with SSO 3. You get redirected to the home page instead of the originally requested inner page. **Expected behavior** We would expect to be redirected to the originally requested page after authenticating with SAML/SSO **Your Configuration (please complete the following information):** - Exact BookStack Version (Found in settings): 31.4 - PHP Version: PHP 7.3.26 - Hosting Method (Nginx/Apache/Docker): Apache 2.4.6 **Additional context** IDP is Azure AD ![2021-02-11 17_33_49-Microsoft Azure](https://user-images.githubusercontent.com/1918286/107714837-91615700-6c93-11eb-9df7-b29fb2c7e162.png) ``` SAML2_NAME=SSO SAML2_EMAIL_ATTRIBUTE=http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress SAML2_EXTERNAL_ID_ATTRIBUTE=uid SAML2_DISPLAY_NAME_ATTRIBUTES=http://schemas.microsoft.com/identity/claims/displayname SAML2_IDP_ENTITYID=https://sts.windows.net/<redacted>/ SAML2_AUTOLOAD_METADATA=false SAML2_IDP_SSO=https://login.microsoftonline.com/<redacted>/saml2 SAML2_IDP_SLO=https://login.microsoftonline.com/common/wsfederation?wa=wsignout1.0 SAML2_IDP_x509=<redacted> ```
OVERLORD added the 🐛 Bug🚪 Authentication🏭 Back-End labels 2026-02-05 02:52:03 +03:00
OVERLORD commented 2026-02-05 02:52:13 +03:00
Author
Owner
Copy Link

@WarriorXK commented on GitHub (Feb 12, 2021):

Same issues here on 31.6, its a minor issue but would be great to see this fixed.

@WarriorXK commented on GitHub (Feb 12, 2021): Same issues here on 31.6, its a minor issue but would be great to see this fixed.
OVERLORD commented 2026-02-05 02:52:18 +03:00
Author
Owner
Copy Link

@kendraspock commented on GitHub (Jun 30, 2021):

We are having this issue as well and it's quite an inefficient process. Would love to see this get resolved ASAP!

@kendraspock commented on GitHub (Jun 30, 2021): We are having this issue as well and it's quite an inefficient process. Would love to see this get resolved ASAP!
OVERLORD commented 2026-02-05 02:52:23 +03:00
Author
Owner
Copy Link

@zimbeo commented on GitHub (Jun 30, 2021):

Please fix! It's a minor issue but greatly affects user experience and usability for things like bookmarks.

@zimbeo commented on GitHub (Jun 30, 2021): Please fix! It's a minor issue but greatly affects user experience and usability for things like bookmarks.
OVERLORD commented 2026-02-05 02:52:29 +03:00
Author
Owner
Copy Link

@tmrhymer commented on GitHub (Jun 30, 2021):

After reading up a bit on this, it looks like most implementations make use of the RelayState mechanism to redirect back to the originally requested URL. Is this something that could be added to Bookstacks implementation?

@tmrhymer commented on GitHub (Jun 30, 2021): After reading up a bit on this, it looks like most implementations make use of the RelayState mechanism to redirect back to the originally requested URL. Is this something that could be added to Bookstacks implementation?
OVERLORD commented 2026-02-05 02:52:37 +03:00
Author
Owner
Copy Link

@benyoung-iw commented on GitHub (Jul 6, 2021):

Running into this as well. Definitely a minor issue, but one that causes friction and hurts adoption for our users.

@benyoung-iw commented on GitHub (Jul 6, 2021): Running into this as well. Definitely a minor issue, but one that causes friction and hurts adoption for our users.
OVERLORD commented 2026-02-05 02:52:42 +03:00
Author
Owner
Copy Link

@pandoraslunchbox commented on GitHub (Aug 10, 2021):

Our business has users request this to support about monthly, it's definitely becoming a headache for people as we get more using this wonderful tool!

@pandoraslunchbox commented on GitHub (Aug 10, 2021): Our business has users request this to support about monthly, it's definitely becoming a headache for people as we get more using this wonderful tool!
OVERLORD commented 2026-02-05 02:52:44 +03:00
Author
Owner
Copy Link

@artschwagerb commented on GitHub (Sep 17, 2021):

Bump, not a php developer but this could be solved with a "next" url parameter.

Users who are not logged in are redirected to the login page with the previous page's relative url set in the "next" url parameter.

After login, if the "next" url parameter exists the user is redirected there. If it does not, the user is sent to the "home" page.

@artschwagerb commented on GitHub (Sep 17, 2021): Bump, not a php developer but this could be solved with a "next" url parameter. Users who are not logged in are redirected to the login page with the previous page's relative url set in the "next" url parameter. After login, if the "next" url parameter exists the user is redirected there. If it does not, the user is sent to the "home" page.
OVERLORD commented 2026-02-05 02:52:47 +03:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 22, 2021):

I'm having the same problem, can someone provide a workaround?

@ghost commented on GitHub (Sep 22, 2021): I'm having the same problem, can someone provide a workaround?
OVERLORD commented 2026-02-05 02:52:52 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Oct 19, 2021):

This is due to the session being lost upon redirection from the idp due to it being a POST request while BookStack session cookies are samesite=lax by default. Also affects SAML request verification.

Maybe we need to introduce a level of redirect loop via get request but the SAML toolkit does run against the current request which can complicate things. Assigned to be looked into for the next release.

@ssddanbrown commented on GitHub (Oct 19, 2021): This is due to the session being lost upon redirection from the idp due to it being a POST request while BookStack session cookies are `samesite=lax` by default. Also affects SAML request verification. Maybe we need to introduce a level of redirect loop via get request but the SAML toolkit does run against the current request which can complicate things. Assigned to be looked into for the next release.
OVERLORD commented 2026-02-05 02:52:55 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Oct 20, 2021):

Addressed within #2996. Will be part of the next feature release.

@ssddanbrown commented on GitHub (Oct 20, 2021): Addressed within #2996. Will be part of the next feature release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 🐛 Bug 🚪 Authentication 🏭 Back-End
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#2091
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?