mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
LDAP: Error when DistiguishedName contains non-English characters #2033
Closed
opened 2026-02-05 02:38:56 +03:00 by OVERLORD
·
7 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#2033
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kurbitz on GitHub (Jan 12, 2021).
Describe the bug
Bug in LDAP Integration. An exception is thrown when users who are members of AD groups who's DistinguishedName contain non-English characters try to log in.
ErrorException: Undefined offset: 0
Laravel log:
https://flareapp.io/share/Bm01pADP#F55
It appears $dnComponents is unexpectedly null because ldap_explode_dn can't handle the non-English characters
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
The LDAP integration checks for any relevant group-memberships and allows the user to sign in.
Your Configuration (please complete the following information):
@csongs commented on GitHub (Jan 14, 2021):
Hi Kurbitz,
I had the same problem before. see #2415
Author writes a tool can encode any non-ascii characters, https://jsfiddle.net/ssddanbrown/4nkwuxj8/3/
@ssddanbrown commented on GitHub (Jan 15, 2021):
Thanks for reporting @Kurbitz,
I'm not so sure it's due to non-English characters, Would have thought we have seen this sooner and, as @csongs has mentioned, others are using groups with non-ascii chars.
Tested on command line,
ldap_explode_dnseems to be okay with the characters:I could only really get
ldap_explode_dnto not return a0index when the dn is genuinely invalid or empty.We do need to have more graceful handling in the code to handle this case either way.
@Swoy commented on GitHub (Jan 21, 2021):
Could this be related to the .env file? The .env file has mime of us_ascii, this has caused issues with passwords as well (mysql and ldap login) since you cannot use non-ascii in that file.
@Vivian-31 commented on GitHub (Jan 22, 2021):
Same issue with us, every ldap member with "not english characters" (é, ä, ..) can connect only one, the second time it says that an user with this email adress already exists. If we change the name in the ldap and replace the characters everything works fine
@ssddanbrown commented on GitHub (Jan 23, 2021):
Hi @Vivian-31, What you're describing sounds like a different issue, more like issue #90
@ssddanbrown commented on GitHub (Feb 8, 2021):
Another thing that could lead to this issue, is not having
LDAP_VERSION=3set otherwise the system may default to old non-utf8-by-default standards.Since there's been no folow-up from the original issue creator after the above guidance, I'll close this off.
@Kurbitz commented on GitHub (Mar 12, 2021):
Hi! Sorry for responding so late. And thanks for all the time you put into this project @ssddanbrown :)
Setting LDAP_VERSION=3 in the .env file solved the issue.
Thanks again!