mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Prevent code blocks breaking when used in include system #1974
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @noxtras on GitHub (Dec 12, 2020).
Describe the bug
Reusing Page Content, Include Tags - code
Steps To Reproduce
Steps to reproduce the behavior:
Your Configuration (please complete the following information):
@ssddanbrown commented on GitHub (Dec 12, 2020):
Hi @noxtras, Are you attempting to include content with inline code or are you attempting to include an entire code block (One with line numbers and syntax highlighting).
@noxtras commented on GitHub (Dec 12, 2020):
Hi, I have tried to include some text and a code block (the whole pre). I also tried editing the page source and add a div and span with an ID to wrap it up and add it to the other page, but no luck, it just won't save it.
@ssddanbrown commented on GitHub (Dec 12, 2020):
Code blocks are a block-level element so you won't be able to include both text and a codeblock using a single include tag unless you're including the whole page.
For the includes of just a code block, we might have to make a tweak to how they're included in so that the whole block is included and not just the contents (We already do this for tables and lists).
@noxtras commented on GitHub (Dec 12, 2020):
I'm OK with two includes, Including the whole code block would be amazing.
Question: What stops me from defining my own HTML block to be included? Like 'edit source' and put the ID in manually for more content.
On a second node, I think that including everything under a header would be nice to have, too.
@ssddanbrown commented on GitHub (Dec 12, 2020):
You can certainly attempt this. If using the WYSIWYG editor you'll find the editor may strip things back to what it supported. The Markdown editor is more liberal in accepting HTML content. Then BookStack will do some level of filtering when content is rendered (Mostly due to security) which could affect things.
I could see that, but it will start to make the logic more complex, while the include system is something I don't want to make too complex as it'd be little utilised in most cases while introducing side affects.
@noxtras commented on GitHub (Dec 12, 2020):
Thank you for the feedback.
@ssddanbrown commented on GitHub (Nov 15, 2021):
I have now updated the content include system to include code blocks along with their top-level pre tags.
This change was made in
e29d03ae76and will be part of the next feature release.Will therefore close this off.