mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Select email address when registering via social account authentication #1949
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ivantomica on GitHub (Nov 19, 2020).
Describe the feature you'd like
When GIthub based authentication is enabled, it would be nice if user were able to select the email address used for creating Bookstack account.
Current behaviour is that with Github driver, primary account email is selected.
Describe the benefits this feature would bring to BookStack users
Many folks have multiple email addresses on their Github profiles. Some of them being provided by the company they work for. This would allow them to specify which address is used for which instance.
@ivantomica commented on GitHub (Nov 19, 2020):
I've since learned that API call to https://api.github.com/user/emails should return all email addresses associated with user-account, their status (primary, verified). I guess selection should only be offered for verified email addresses due to security reasons (anybody can add unverified email address to their profile, and would thus get access to wiki as well).
@ssddanbrown commented on GitHub (Nov 22, 2020):
Thanks for the suggestion @ivantomica.
To be totally honest, I don't really want to go down the path of adding in edge-case functionality/interface for specific social providers.
From what I can remember, BookStack will only use the GitHub email address when registering as a new account, Any attachment between the GitHub & BookStack users are then based upon ids. You should be able to still change emails addresses in BookStack after initial registration, if wished for, or sign-up via another method then attach the GitHub account to your account afterwards.
@ivantomica commented on GitHub (Nov 22, 2020):
Agreed, we should always be reluctant when adding new "edge-case" functionality.
In this particular case though, when you give it some more thought, it isn't so wild :-)
When registering for an account, if I have domain limitation, I can't complete registration unless my primary email is in allowed domain name list. This is not so rare as many folks use their private github accounts as organization accounts as well. And as you can imagine, many folks can be in few different organizations.
My proposition was to simply allow email to be choosen during the registration, this way, you wouldn't add any security risk in the process. If only verified addresses were listed that is :-)
@ssddanbrown commented on GitHub (Nov 26, 2020):
Sure, I get the idea of it and agree that it isn't so wild, but it is still very edge-case. Including such functionality would only greatly benefit:
It's gonna end up a fraction of a percent of use-cases.
@ssddanbrown commented on GitHub (Dec 12, 2020):
Due to the above I'm going to close this off. Thanks though for spending the time in putting forward the idea.