mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 11:19:36 +03:00
Ensure "images with dots in file-name" error message shows localised message #1885
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DevMimas on GitHub (Oct 4, 2020).
Describe the bug
A graphic drawn in diagrams.net and exported as png file cannot be inserted as an image. It is always said that it is a wrong file extension. Unfortunately I can't describe it better because it works strangely with other png images.
Would be important to fix it quickly.
Steps To Reproduce
Steps to reproduce the behaviour:
Screenshots
Your Configuration (please complete the following information):
linuxserver/bookstack:v0.30.2-ls106@DevMimas commented on GitHub (Oct 5, 2020):
Okay, false alarm. I had a dot in the file name, that was the problem. It works.
On the other hand, the translation for it is completely missing. DE selected EN displayed. Also the error message is a bit minimalistic, I think.
@ssddanbrown commented on GitHub (Feb 7, 2021):
I've given this a test, User-facing message seems to be translated as expected when using both types German available.
Error message could indeed be clearer, but there's an existing issue to handle this different so don't want to cause time spent on changing error messages if it'll be soon redundant.