mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 19:06:05 +03:00
The button on the top right cannot be clicked on mobile phone view in 0.30.1 #1871
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MFYDev on GitHub (Sep 28, 2020).
Describe the bug
When using 0.30.1 BookStack, the top right button on mobile view cannot be clicked because of a js error
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
The button should be able to be clicked and unfold to display the log in button and other functions.
Screenshots
Your Configuration (please complete the following information):
@ssddanbrown commented on GitHub (Sep 28, 2020):
Hi @MFYDev,
Can you provide any version information? This does not seem to occur in my own testing.
Tested on Chrome Version 85.0.4183.121 (Desktop) and Version 85.0.4183.127 (Android Device)
@MFYDev commented on GitHub (Sep 29, 2020):
@ssddanbrown Hi mate, I just upgrade the chrome and edge to the latest version on google play.
And I found that chrome does not have this problem, but edge, which version is 45.08.4.5072, the latest, still has this issue.
I really wonder why because both of theme are chromium core. You can test it with edge.
@ssddanbrown commented on GitHub (Sep 30, 2020):
@MFYDev Thanks for confirming, Have tested on android edge and confirm the same issue.
From my research, it seems that for the Android Edge build, they lag behind a bit on the chromium version in use. Currently reports as version 77 which is about a year old.
Also had reports about recent changes breaking Firefox ESR releases, Think I need to dial back how aggressively modern JS is used or built by our tools.
@ssddanbrown commented on GitHub (Oct 1, 2020):
@MFYDev I've just published version 0.30.2 with some changes in the build system to go a little further back. Seems to solve things from my testing on my phone but could you update and let me know if that solves this for you?
@MFYDev commented on GitHub (Oct 1, 2020):
It seems that Edge and Firefox have deliberately kept their kernel versions old for maximum stability and compatibility. Thank you for your quick reply and powerful update！:D
I can make sure that 0.30.2 completely works fine with Edge. But actually after this, I will switch back to Chrome to use the latest chromium.
@ssddanbrown commented on GitHub (Jan 16, 2021):
Thanks for confirm this was fixed @MFYDev.
Will therefore close.