mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
Drawings - draw.io breaking #1870
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kabe0 on GitHub (Sep 28, 2020).
When you click the drawing button in the editor, it appears to present a broken image. The URL throws a 301 redirect
If you open the link in the browser draw.io say's the following
@nutsflag commented on GitHub (Sep 28, 2020):
Hello,
What is your version?
Thanks
@Kabe0 commented on GitHub (Sep 28, 2020):
BookStack v0.30.1, though it also happens on the demo on the main Bookstack website.
Seems to affect only Chromium based browsers right now.
@nutsflag commented on GitHub (Sep 28, 2020):
Okay,
I just tested with Firefox, Google Chrome and Edge with the demo version.
I didn't have any problem.
@Kabe0 commented on GitHub (Sep 28, 2020):
Confirm the chrome version, as they are adding a lot of permission changes in the more recent builds.
Chrome version: 85.0.4183.102
@nutsflag commented on GitHub (Sep 28, 2020):
I just tried with Chromium (Version 87.0.4277.0). I don't have any problem.
For my Chrome version : Version 85.0.4183.121 (Official Build)
No errors either.
@Kabe0 commented on GitHub (Sep 28, 2020):
You sure your not cached? The issue is caused by this line specifically x-frame-options: SAMEORIGIN which stops cross frame iframe displaying. Do you see this line in the response headers?
This is the URL that is returning that header data: https://app.diagrams.net/?embed=1&proto=json&spin=1
I think changing the request to embed.diagrams.net will resolve this issue.
@nutsflag commented on GitHub (Sep 28, 2020):
Is it possible for you to make a modification on your server?
If yes, then go to: resources/views/pages/
Save the file form.blade.php and modify line 4 with :
drawio-url="{{ is_string(config('services.drawio')) ? config('services.drawio') : 'https://embed.diagrams.net/?embed=1&proto=json&spin=1' }}"
@Kabe0 commented on GitHub (Sep 28, 2020):
works!
@nutsflag commented on GitHub (Sep 28, 2020):
Does it work with modification?
@Kabe0 commented on GitHub (Sep 28, 2020):
Yep, it works as expected on existing and new ones.
@ssddanbrown commented on GitHub (Oct 1, 2020):
As of BookStack v0.30.2 the default URL has now been updated to be the diagrams.net embed URL.
Thanks for your time in helping here @nutsflag.