mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-23 11:19:38 +03:00
Role changes by admin require password user #1866
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @stonemaker01 on GitHub (Sep 24, 2020).
While i was upgrading users roles, i was forced to confirm the password. As admin i should not hold users passwords. Upgrading an user with new role, should be done without confirming the password.
Actually, the settings page does not ask for the password, but wont allow me to safe the changes, without this confirmation.
Anybody an idea how to solve?
@ssddanbrown commented on GitHub (Sep 26, 2020):
Hi @stonemaker01,
Are you sure this is the case? The functionality is there in the event an admin needs to force change a password.
You should be able to change other details and leave the password fields empty to update the record without password change.
I have just tested this and it seems to work as expected.
@stonemaker01 commented on GitHub (Sep 26, 2020):
Hello sir,
I have done the change again reversed, and same issue appeared. Confirm the
password of that particular user.
I was suprised myself too.
Op za 26 sep. 2020 12:07 schreef Dan Brown notifications@github.com:
@ssddanbrown commented on GitHub (Sep 26, 2020):
Okay, Before you press "Save" or "Update" when making changes to a profile, Is there any content within either of the password inputs? Or are they empty?
@stonemaker01 commented on GitHub (Sep 26, 2020):
It is empty.
Op za 26 sep. 2020 13:44 schreef Dan Brown notifications@github.com:
@ssddanbrown commented on GitHub (Sep 26, 2020):
Okay, Strange.
And on the settings page, What version of BookStack is shown?
@stonemaker01 commented on GitHub (Sep 26, 2020):
That is 0.30.0
I have not tried the same route in previous version.
Op za 26 sep. 2020 13:47 schreef Dan Brown notifications@github.com:
@stonemaker01 commented on GitHub (Sep 30, 2020):
Hi. I noticed a difference:
Once an useraccount has a password dashed in the first block, any
adjustment in the user settings must be confirmed by a password in the
second block.
When there is no password in the first block, i can change anything in the
settings of the account.
There is somewhere an dependence build in, when passwords are set manually.
Op za 26 sep. 2020 13:47 schreef Dan Brown notifications@github.com:
@ssddanbrown commented on GitHub (Sep 30, 2020):
@stonemaker01 Yes, that is intentional, The second input is a confirmation block that is required to match the first input. This logic will only run if a new value is provided in the first input, otherwise the system will assume no changes need to be made to passwords at all.
@ssddanbrown commented on GitHub (Jan 16, 2021):
Since the issue was not confirmed here I'll close this off.