mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Bug: User's password validation rules mismatch across application #1835
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jakubboucek on GitHub (Aug 31, 2020).
Describe the bug
Password validation rules is mismatch across application.
Mismatch explain
CreateAdmin– 5 characters ruleIn
\BookStack\Console\Commands\CreateAdmin::handle()is validation rule for password only 5 chars length:13c0386e84/app/Console/Commands/CreateAdmin.php (L72-L74)RegisterController– 8 characters ruleIn
\BookStack\Http\Controllers\Auth\RegisterController::validator()is validation rule for password only 5 chars length:e15fcf5b50/app/Http/Controllers/Auth/RegisterController.php (L62-L69)l10n – 5, 6, 7, 8 characters rule description
Reqiurements for password is mismatched between languages in l10ns files.
Expected behavior
I expect keep requirements for same entity's property same across whole application.
Better way can be extract password validation to one helper.
Don't worry be happy
I am offering to help you with reunite it by Pull Request, just help me confirm the 8 character length is currently valid length for Users passwords in application.
@ssddanbrown commented on GitHub (Sep 5, 2020):
Hi @jakubboucek,
Thanks for offering a pull request.
Yeah, 8 characters if currently the valid length.
@ssddanbrown commented on GitHub (Dec 18, 2021):
Thanks again for reporting @jakubboucek,
This has been addressed in
bb9cd9d610to be part of the next feature release.