mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-07-16 05:33:49 +03:00
Dark mode decreases performance #1762
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maderschramm on GitHub (Jun 11, 2020).
Describe the bug
Using Safari on macOS 10.15 I am experiencing massive slowdowns using Dark Mode - especially when trying to link pages, but also when scrolling normally.
The issue is mostly remediated with other browsers, but is still somewhat present.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
Performance should be the same regardless of which theme is enabled - light or dark.
Screenshots
See the below .gifs:
Links in Dark Mode:
Links in Light Mode:
Scrolling in Dark Mode:
Scrolling in Light Mode:
Your Configuration (please complete the following information):
Additional context
macOS 10.15.5
Safari Version 13.1.1 (15609.2.9.1.2)
@ssddanbrown commented on GitHub (Jun 21, 2020):
Thanks for reporting @maderschramm, I'll try and have a look for the next release. Is likely some css filters we're using in dark mode causing trouble.
@ssddanbrown commented on GitHub (Jul 26, 2020):
Thanks again for reporting @maderschramm.
Found this same thing in my testing on my mac mini test machine. Unfortunately I could not find the exact cause, Did not seem to be the filters alone. I did find that when the editor was forced onto its own rendering layer performance would greatly improve.
Changes will be part of v0.30. If you still have performance issues after that release please feel free to open a new issue, referencing this one and we'll debug further.