mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Ordered list with >=100 items omits first digit of ordinal #1607
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wlabarron on GitHub (Mar 23, 2020).
Describe the bug
When an ordered list has more than 100 items, the first digit of the number is hidden - so “100” displays as “00”, “101” displays as “01”.
Steps To Reproduce
Create an ordered list of 100 or more items.
Expected behavior
Numbers should appear fully, without missing digits.
Your Configuration (please complete the following information):
@james-geiger commented on GitHub (Mar 23, 2020):
@wlabarron Could you post a screenshot of what it looks like on your machine?
I did this on my Dev instance, and it worked as expected:
@wlabarron commented on GitHub (Mar 23, 2020):
Please excuse the image being so thin, I'm not sure how public the content is allowed to be. The screenshot is items 98-105. Could it be because in the Markdown editor I've added headings in between some items, and it's tripped something up somewhere?
@james-geiger commented on GitHub (Mar 23, 2020):
@wlabarron I'm really trying to break this:
One important thing to understand is that BookStack is just generating the HTML markup that is then interpreted by your browser. This is the markup that was generated for the screenshot above:
This most likely has something to do with CSS. In this screenshot, I've manually overridden the left-padding on the
<ol>element, creating what appears to be a truncation:Have you applied any style overrides that could have caused this to display improperly?
@wlabarron commented on GitHub (Mar 23, 2020):
Thank you for investigating this. I've applied no style overrides, just changed the theme colour in Settings.
The HTML generated (with my data removed) is:
I've just been playing and found that by using the Inspector in my browser (Safari) to remove the
padding: 0;which is applied tohtml, body, div, span, applet, object,and many other things, and removing thepadding-left: 32px;which is applied toolmakes the numbers appear properly. Furthermore, it displays correctly with no changes in Firefox. Perhaps a Safari bug?@james-geiger commented on GitHub (Mar 24, 2020):
Confirming that this seems to be a safari issue that does not exist in blink/gecko rendering engines.
@ssddanbrown commented on GitHub (Apr 5, 2020):
Strangely, does not occur on gnome-web either. Can confirm I can see it on iPad though.
@ssddanbrown commented on GitHub (Apr 5, 2020):
There was a
overflow: hidden;applied to all lists. Not sure why, probably the wrong fix to an issue a long time ago. Have now removed, will be part of the v0.29 release.Think this was mainly affecting Safari as it's default font or text rendering has wider letter-spacing.