mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
WYSIWYG editor modal windows overflow the screen on mobile #1578
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hjyoung1 on GitHub (Mar 7, 2020).
Describe the bug
A clear and concise description of what the bug is.
1st i want to say thank you so much for making this.
I tried so many such services but this is so much better, thank you.
Now for bug it's just normal scaling issues on mobile screen.
With source code and insert media modal in wysiwyg editor.
Steps To Reproduce
Steps to reproduce the behavior:
Open any page in edit mode and tap on source code or insert media button.
Expected behavior
A clear and concise description of what you expected to happen.
I expect modal to adapt properly like it adapts completely on https://www.tiny.cloud both button modal here is fully responsive.
Screenshots
If applicable, add screenshots to help explain your problem.
Your Configuration (please complete the following information):
Additional context
Add any other context about the problem here.
Not related to above issue.
But i have two questions regarding editor as bookstack is using TinyMCE then why this looks different than https://www.tiny.cloud/features
Also is it possible to add more TinyMCE plugins or themes/skins like wordcount or spell checker?
@ssddanbrown commented on GitHub (Mar 8, 2020):
Thanks!
That is the fully featured TinyMCE 5 instance, shown on their website. BookStack is using a customised TinyMCE 4 instance, Hence the differences. They added better mobile support overall in TinyMCE 5.
As part of the roadmap, we'll soon be reviewing the editors and potentially be replacing TinyMCE as the solution hence the lack of upgrade to 5 at this time.
Yes, it is possible but you'd need to be familiar with JavaScript. We expose the editor config via events as described here:
https://www.bookstackapp.com/docs/admin/hacking-bookstack/#bookstack-editor-events
It would be a case of using these events to alter the editor config as you wished. Note that we don't really provide support for these kind of customizations though and any custom additions you add to TinyMCE may be lost or not possible if we change to a new editor.
@Tzeenchist commented on GitHub (May 17, 2020):
This problem concerns not only the tools, but also the inserted content. For example, videos from YouTube also go beyond the screen of a mobile phone.
@KarenArzumanyan commented on GitHub (Apr 25, 2022):
The current version of the editor in BookStack is very little functional and inconvenient.
What can be expected in the near future? Changing the editor to another or updating to a newer version of TinyMCE 6.0.1?
@ssddanbrown commented on GitHub (Apr 25, 2022):
I'll go ahead and close this off since the fundamental reports issues have been addressed in our update to TinyMCE 5 from release v22.02. Some of our own custom modals are still not responsive but there are other focused issues for those (Such as #2535).
@KarenArzumanyan Don't expect things to change too much. We'll probably update to TinyMCE 6 in the future but we'd probably attempt to keep things very much the same in terms of functionality.