mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Install dev packages into production, is this correct? #1564
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joveice on GitHub (Mar 2, 2020).
Describe the feature you'd like
Installation documentation mentions installing using
composer install. Shouldn't this becomposer install --no-dev?Describe the benefits this feature would bring to BookStack users
Does not install development packages into "production"
@homotechsual commented on GitHub (Mar 2, 2020):
Just confirming that this works and results in a working production instance.
@ssddanbrown commented on GitHub (Mar 2, 2020):
Yeah, probably worth doing. I ideally want to avoid composer being required at all for production setups so never looked to optimised it, but that's likely still a way off so have marked this to be updated before next release.
@Reflic commented on GitHub (Mar 5, 2020):
Thumbs up for this one. I am doing this in two production environments and it did not have any negative impact so far.
@joveice commented on GitHub (Mar 5, 2020):
Just fired up my own and it seems to work without issues when not installing dev packages.
Note there might be some packages in the non dev that could be moved to dev.
@ssddanbrown commented on GitHub (Mar 6, 2020):
Thanks for confirming everyone.
I've now updated the docs and install scripts to use
--no-devmode. Will therefore close this.