mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
400 interaction_required #1540
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ch0wm3in on GitHub (Feb 16, 2020).
Describe the bug
When using socialite provider for azure + Conditonal access with MFA, it will not allow MFA through bookstack.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
To be logged into the application
Screenshots
If applicable, add screenshots to help explain your problem.
Your Configuration (please complete the following information):
Additional context
Please see my pull request which fixes above, it is a fix recommended by socialite provider.
https://github.com/BookStackApp/BookStack/pull/1889#issue-374326205
@ch0wm3in commented on GitHub (Mar 3, 2020):
@ssddanbrown Any plans for merging?
@ssddanbrown commented on GitHub (Mar 3, 2020):
@ch0wm3in Yes, I do plan to. Just haven't got round to it yet as I'd need to spend some time understanding how it fixes the issue and if it will possibly cause issues for existing setups.
@ssddanbrown commented on GitHub (Mar 6, 2020):
As mentioned on #1889, Tested on my dev instance, which did not have this issue, and did not cause any side-effects there (Thinking of existing users), so now merged to be part of the next patch release.
Thanks for reporting and fixing @ch0wm3in.