mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
EXIF data is ignored when uploading images #1501
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JetUni on GitHub (Jan 20, 2020).
Describe the bug
When inserting an image that has EXIF rotation data, the rotation of the image isn't respected in the output.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
The EXIF rotation data should be considered when uploading the image so that it will display correctly
Screenshots
Your Configuration (please complete the following information):
@alexmannuk commented on GitHub (Aug 24, 2020):
I've tested this on my own setup with v0.29.3 using Apache on Ubuntu 18.04 with PHP 7.2.24 and images appear to display rotated correctly. Either this is fixed in later versions of BookStack or you need to make sure php-exif is installed on your web server.
@cod3monk commented on GitHub (Feb 19, 2022):
I encountered the same problem running v21.12.1 using the latest solidnerd/bookstack docker image.
As the docker container does not install the exif php extension (explicitly), I have installed it manually and it did not make any change on reuploaded files. Same for mbstring.
Example
Page where image is used: link (may have changed in the meantime)
Original file: link (with correct rotation included in EXIF data)
Scaled file: link (missing all EXIF data, including rotation)
Expected Behavior
Either
Related
https://github.com/Intervention/image/issues/886
@ssddanbrown commented on GitHub (Mar 26, 2022):
Thanks @cod3monk.
Sounds like we should call orientate in our thumbnail generation chain to alter the image to match exif rotation.
Will assign to next feature release to check, and implement this route if found viable.
@ssddanbrown commented on GitHub (Mar 26, 2022):
Okay, not as simple as hoped.
By the time the intervention image instance has been created from image data the orientation exif is lost. Happens when creating and export an image via
gdin general. Not a simple thing to patch upstream either unfortunately.Instead we'll likely have to manually convert the image data to a stream on our side then read the
exif_read_dataoutput and then copy Intervention's orientate logic to achieve the desired output.@ssddanbrown commented on GitHub (Mar 26, 2022):
If have now applied
55d61fceb2which re-implements intervention's orientation based upon exif data from original image data.This will be part of the next feature release so I'll therefore close this off.
@EricChen1248 commented on GitHub (Sep 10, 2022):
Just leaving a comment for users who are stupid like me and still find it not working.
If you are using linuxserver.io's version of bookstack, you need to create a custom docker image off of it and add php8-exif, as this fix relies on that.
It's likely the same for solidnerd's version, but I didn't test it.
@Skillkiller commented on GitHub (Oct 13, 2024):
Fixed by
248b8769b4