mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 08:39:55 +03:00
AD groups starting with # don't work for Role External Authentication IDs #1420
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GitAdrianHub on GitHub (Oct 24, 2019).
Active Directory security groups that start with # (our standard) don't work for mapping AD groups to Roles using either the Role Name or External Authentication IDs. When A user who is a member of that group logs in, their role will not be applied.
Ubuntu 18.04 fresh install and used the supplied Ubuntu install script and supplied ldap config.
@ssddanbrown commented on GitHub (Oct 26, 2019):
Hi @GitAdrianHub,
I've had a little play on my side on this although I'm using OpenLDAP instead of AD.
It's a bit awkward since hash is not a valid character on its own and has to be escaped within a DN.
While testing I found that the BookStack side of things receives an escaped character code instead of a hash itself.
When setting an "External Authentication ID" on role of
\23groupname(So a\23instead of a#) I found it would then match correctly. Can you give this a go on your side to see if that gets things working?@GitAdrianHub commented on GitHub (Oct 28, 2019):
That seems to work, thank you!
@ssddanbrown commented on GitHub (Oct 28, 2019):
@GitAdrianHub Awesome! I'll therefore close this off, Hopefully should not be a frequent issue but if it pops up again I'll keep this in mind and potentially add a note to the docs.
Thanks for confirming!