mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 09:09:38 +03:00
Dotted outline when clicking on a button/link #1418
Closed
opened 2026-02-05 00:50:41 +03:00 by OVERLORD
·
8 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#1418
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @clafee on GitHub (Oct 23, 2019).
Originally assigned to: @ssddanbrown on GitHub.
Hello,
First of all thank you for this wonderful application !
Describe the bug
I upgraded from 0.26.4 to 0.27.5, and now I have a dotted outline when I click on anything clickable. The outline disappears after the content has loaded
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
No outline when clicking on anything.
Screenshots

Your Configuration (please complete the following information):
Thanks !
@james-geiger commented on GitHub (Oct 23, 2019):
Duplicate of #1678
Hi @clafee --
This was an intentional change made between v 0.26.x and v 0.27.x outlined in the issue I mentioned.
It was done to increase accessibility.
@ssddanbrown commented on GitHub (Oct 23, 2019):
Hi @clafee,
As suggested above there were some intentional changes in v0.27 to increase accessibility of the platform. That said, The sizing of the outline shown in the screenshot is much larger than I'd expect.
Could you confirm the following:
@clafee commented on GitHub (Oct 24, 2019):
Sorry, I tried to search before posting, guess it wasn't enough.
Here are your answers @ssddanbrown
Please confirm your exact browser and operating system version. I tried on Firefox 69.0.3, Microsoft Edge 42.17134.1.0, Vivaldi 2.2.1388.34 (I haven't updated this one in a while). All of that on Windows 10
What I didn't notice is the outline that is a different size between the first two browsers and Vivaldi.
Please confirm if you also see the same focus style on the demo site.

Here's what I have on Firefox 69.0.3 on the demo site:
And here's what I have on Vivaldi 2.2.1388.34:

Based on what you said, I believe it all looks normal, sorry for wasting you time, and thanks again for this great software !
@james-geiger commented on GitHub (Oct 24, 2019):
Could be addressed by setting the
outline-widthproperty on the:focusselector, e.g.:It appears that when it's not explicitly set the browser uses
whatever the base text size is a reference pointits base style sheet to determine the size.@dannyhanes commented on GitHub (Nov 25, 2019):
Adding on to this, I am all for supporting accessibility, but perhaps there could be a toggle within the settings to enable / disable accessibility features. For me it looks a little silly.
@rohithb commented on GitHub (Nov 26, 2019):
If you want to turn it off, just add
in Custom HTML Head Content under settings.
@dannyhanes commented on GitHub (Nov 26, 2019):
@rohithb Well that was easy enough, thanks!!
@ssddanbrown commented on GitHub (Dec 16, 2019):
Thanks @james-geiger for the suggestion. I've applied some sensible default values in commit
a9634b6b66. These will be part of the next release (v0.28) which is targeted for release at the end of the year.If anyone would like to disable outlines completely please follow the suggestion from @rohithb above but please keep in mind that outlines may be important for some of your users, both those with visual impairments and also those that like to navigate by keyboard.