mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-05-04 18:08:46 +03:00
Page version number increases even if no changes were made prior to saving #1416
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Wookbert on GitHub (Oct 23, 2019).
Describe the bug
If you open a page, go into edit mode and save the page without actually making any change, BookStack creates a new version which is of course absolutely identical to the existing/prior version.
Expected behavior
When clicking onto „Save page“, BookStack should leave edit mode and a dialogue should show up reading "No changes were made, thus no new version created.“
@mflagler commented on GitHub (Feb 21, 2020):
Why not just hit the back button instead of the save button? If you have made changes, it will prompt you before actually going back.
@ssddanbrown commented on GitHub (Feb 12, 2021):
Thanks for reporting @Wookbert, Did not see that #1846 was a duplicate of this.
There were some checks in place to prevent unrequired revisions but they were not working as intended. This has now been patched in
5323cb5224, to be part of the next feature release.