v0.27.0 baseUrl -> url function issue #1331

Closed
opened 2026-02-05 00:37:45 +03:00 by OVERLORD · 5 comments
Owner

Originally created by @neoty on GitHub (Sep 1, 2019).

Originally assigned to: @ssddanbrown on GitHub.

Describe the bug
All links on the web page have been changed to http

Steps To Reproduce
Steps to reproduce the behavior:

  1. Clone release branch (or download release archive 0.27.0)
  2. Server on nginx(https) -> docker(http) proxy
  3. when access to home page, all links changed to http
    browser warning https site but load http resource

Expected behavior
all resource load fine

Screenshots

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): 0.27.0
  • 443 - nginx -> 80 nginx+php-fpm docker

Additional context
Previously, the way to get url was to call baseUrl. In this distribution, it is changed to url function. It seems to be related to this.

.env content
APP_URL=https://wiki.seq.kr

스크린샷 2019-09-01 오후 1 33 30
Originally created by @neoty on GitHub (Sep 1, 2019). Originally assigned to: @ssddanbrown on GitHub. **Describe the bug** All links on the web page have been changed to http **Steps To Reproduce** Steps to reproduce the behavior: 1. Clone release branch (or download release archive 0.27.0) 2. Server on nginx(https) -> docker(http) proxy 3. when access to home page, all links changed to http browser warning https site but load http resource **Expected behavior** all resource load fine **Screenshots** **Your Configuration (please complete the following information):** - Exact BookStack Version (Found in settings): 0.27.0 - 443 - nginx -> 80 nginx+php-fpm docker **Additional context** Previously, the way to get url was to call baseUrl. In this distribution, it is changed to url function. It seems to be related to this. .env content APP_URL=https://wiki.seq.kr <img width="810" alt="스크린샷 2019-09-01 오후 1 33 30" src="https://user-images.githubusercontent.com/19975402/64071886-3f0ac100-ccbf-11e9-8fae-b39549335857.png">
OVERLORD added the 🐛 Bug label 2026-02-05 00:37:45 +03:00
Author
Owner

@ssddanbrown commented on GitHub (Sep 1, 2019):

Hi @neoty,
Did you manage to resolve this one? Your site seems to be using the https links as expected right now.

@ssddanbrown commented on GitHub (Sep 1, 2019): Hi @neoty, Did you manage to resolve this one? Your site seems to be using the https links as expected right now.
Author
Owner

@neoty commented on GitHub (Sep 1, 2019):

@ssddanbrown
Yes I solved
But that's temporary.

cd /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation
vi helpers.php

line 934
before -> return app(UrlGenerator::class)->to($path, $parameters, $secure);
after -> return app(UrlGenerator::class)->to($path, $parameters, true);

and it works.

@neoty commented on GitHub (Sep 1, 2019): @ssddanbrown Yes I solved But that's temporary. ``` cd /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation vi helpers.php line 934 before -> return app(UrlGenerator::class)->to($path, $parameters, $secure); after -> return app(UrlGenerator::class)->to($path, $parameters, true); ```` and it works.
Author
Owner

@ssddanbrown commented on GitHub (Sep 1, 2019):

@neoty Thanks for the details and thanks for originally reporting.

I've pretty sure I've managed to find the cause of this and have updated BookStack with a fix and test to cover:
7a4425473b

I've just deployed v0.27.2 to include this. Would you be able to revert your change, update & let me know if this release solves the issue for you?

@ssddanbrown commented on GitHub (Sep 1, 2019): @neoty Thanks for the details and thanks for originally reporting. I've pretty sure I've managed to find the cause of this and have updated BookStack with a fix and test to cover: 7a4425473b61007f6eee51a3f794f5908cd2ccd8 I've just deployed v0.27.2 to include this. Would you be able to revert your change, update & let me know if this release solves the issue for you?
Author
Owner

@neoty commented on GitHub (Sep 1, 2019):

@ssddanbrown

I applied it to version v0.27.2 and the issue seems to be resolved on my site.
Thank you for your hard work.

@neoty commented on GitHub (Sep 1, 2019): @ssddanbrown I applied it to version v0.27.2 and the issue seems to be resolved on my site. Thank you for your hard work.
Author
Owner

@ssddanbrown commented on GitHub (Sep 1, 2019):

Awesome, Thanks for checking! Will therefore close this.

@ssddanbrown commented on GitHub (Sep 1, 2019): Awesome, Thanks for checking! Will therefore close this.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#1331