mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Copy shelf permission to a book when the book is created directly within a shelf #1313
Open
opened 2026-02-05 00:34:32 +03:00 by OVERLORD
·
10 comments
No Branch/Tag Specified
development
l10n_development
further_theme_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
No Label
🔨 Feature Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#1313
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mattstanyon-tall on GitHub (Aug 27, 2019).
Would it be possible to have new books inherit the permissions of the shelf they are created under (assuming they are indeed created under a shelf)?
My understanding is the permissions set on shelves do not propagate unless you use the copy permissions, therefore I don't think this would cause a conflict, but it would mean there is one less step many users need to perform, by default.
@ssddanbrown commented on GitHub (Aug 27, 2019):
Hi @mattstanyon-tall,
Thank you for your request. It'll be worth looking at my comments here:
https://github.com/BookStackApp/BookStack/issues/1091#issuecomment-433408458
Where I detail the complexity in Shelf -> Book auto-permission inheritance.
@mattstanyon-tall commented on GitHub (Aug 28, 2019):
Hi @ssddanbrown
I reviewed this, however, I was wondering if this could be set on initial creation only, which is slightly different from the previous request. Understanding that once a book has been created it could then be a member of various shelves, etc.
However, if you select Shelf > Create a new book, my request is whether this new book could inherit/copy the permissions from the Shelf. Post creation, the permissions on the books might change, and the book might become a member of different shelves etc.
Perhaps we are using the product in a different way from intended, but, if most books are created from within a shelf, rather than added to shelves later, this seems logical (to me!).
I haven't fully got my head around how the permissions on Shelves work in regard to items within that shelf - perhaps this is causing some confusion, in which case, my apologies.
As we push BookStack into the org here, this is one of the items which has come up from various different user groups. Perhaps the command-line tool you mentioned would resolve this, this is just a slightly different use-case/approach.
Finally, the remaining feedback is fantastic. You have a great product, so thank you for the time and effort invested.
@ssddanbrown commented on GitHub (Sep 1, 2019):
Thanks for the positive feedback.
I get what you mean and can see how this would be helpful. I'll update the issue title to reflect the core request.
@ssddanbrown commented on GitHub (Oct 30, 2019):
Related comment from #1726
@alexphillips-dev commented on GitHub (Jun 18, 2022):
Please add an option to copy permissions during book creation via shelf context. Or enable an inheritance option ;)
@tacerus commented on GitHub (Sep 24, 2022):
Hi,
I'd like to add that this would be very interesting from a security perspective as well - currently, if someone creates a new book, it is temporarily publicly visible until the owner goes into the Permissions menu and clicks the copy button.
Unfortunately I'm not that proficient with PHP myself and only use this for a private project, but I'd be happy to pay someone a couple of beers for implementing such a "Apply Permissions from Shelf" checkbox on the book-creation page.
@Ronald4300 commented on GitHub (Oct 4, 2022):
Hi
I think this would be very useful, too. Most - if not all - books we created up so far were created within the shelf context. So if a newly created book could inherit the shelf permissions, this would help a lot.
@nightsparc commented on GitHub (Oct 7, 2022):
Full ACK to @tacerus and @Ronald4300.
We're currently forced to heavily restrict the shelf/book creation, as we had a lot of permissions problems in the past. This is a real pity, as we are generally are very happy with Bookstack and especially appreciate its simplicity and ease of use.
So, either having a checkbox
Copy permissions from parentin the book/shelf creation process or automatically deduce permissions (maybe de-/activatable and configurable in the settings) would help a lot.@Sulkar commented on GitHub (Feb 24, 2024):
Here is an easy Logical Theme solution: #4411
@kobaz commented on GitHub (Jul 25, 2024):
This is 100% needed. It looks like the same sort of issue from another post I found when researching this problem:
https://www.reddit.com/r/BookStack/comments/tea7ez/permissions_issue_looking_for_some_advice_please/
Why allow a user to create books but then disallow them to be able to access it once it's created (assuming they also have edit permission).
It seems really really really limiting to allow a user to create a book but they can't see it once they create it. It really destroys self-sufficiency.