mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 11:19:36 +03:00
Make 'changes' view more visual to highlight specific differences between edits #1287
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @samtuke on GitHub (Aug 1, 2019).
Describe the feature you'd like
On the default view of BookStack v0.26.3 for changes between edits, the changes are unclear because they are not highlighted or use visual conventions communicate what changed.
For example in the screenshot provided, it is unclear what changed, if anything, in the content displayed.
Wordpress, Meld, and etherpad are three examples of applications that use clearer visual signs to show what changed.
This functionality is important for managing spam and hunting down small undesirable edits from spammers.
Describe the benefits this feature would bring to BookStack users
Users would be able to understand at a glance what has changed and whether it should be reverted. This is part of the necessary collaboration and content management of a manual with a large community and open registration.
@ssddanbrown commented on GitHub (Aug 3, 2019):
The changes view does have some level of visual aid for changes:
There are changes, content and situations that the system has troubling diffing & visualising though. I'm sure some improvements can be made to this.
@bensulli commented on GitHub (Oct 25, 2019):
Actually I think there's an underlying bug here. Looking at @samtuke 's screenshot, I see the same thing, where the formatting is all weird and only the first few characters of each line are shown.
I can't get it to show the full text with changes like in @ssddanbrown 's screenshot. So I think this might just be a bug with revision display.
Eg, this is a page I did revisions on.
@samtuke commented on GitHub (Oct 26, 2019):
Is it to do with PHP server version?
@bensulli commented on GitHub (Oct 29, 2019):
Could be? I'm just using Bookstack in docker (https://github.com/linuxserver/docker-bookstack) which I would've thought was a common use case.
PHP 7.2.18 (cli) (built: May 4 2019 16:25:12) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
@setpill commented on GitHub (Apr 10, 2020):
The diff view is still quite poor in clarity sometimes.
An example is this demo revision. Or any revision of the examples of different content page is really hard to see because there are so many other things going on.
One option would be to mark changed/deleted/added lines in the margin so that the actual content of the page cannot interfere.
@ssddanbrown commented on GitHub (Feb 13, 2021):
Coming back to this, I think the original issue was due to a bug within the php-tidy extension on some systems as discussed here: #1553
The latest release of BookStack no longer uses
php-tidyso the original issue experienced should no longer be apparent so will therefore close this.@bensulli commented on GitHub (Feb 13, 2021):
Confirmed this is fixed in the latest build we're using! Thanks!
@setpill commented on GitHub (Feb 22, 2021):
Is the demo up to date? Because in the examples I gave it still is very hard to see what changed/how.