Clean up code suggestion for permission system and etc. #1253

New Issue

OVERLORD · 2026-02-05T00:24:44+03:00

OVERLORD commented

2026-02-05 00:24:44 +03:00

Originally created by @imanghafoori1 on GitHub (Jul 10, 2019).

Hi, I reviewed your code base and saw that you can clean up and make it more flexible and modular using my open-source laravel packages, (like : laravel-widgetize, laravel-heyman, laravel-decorator)

I can create PRs for you, but before that I wanted to ask if you allow for additional composer dependencies in pull requests or not ?

Originally created by @imanghafoori1 on GitHub (Jul 10, 2019). Hi, I reviewed your code base and saw that you can clean up and make it more flexible and modular using my open-source laravel packages, (like : laravel-widgetize, laravel-heyman, laravel-decorator) I can create PRs for you, but before that I wanted to ask if you allow for additional composer dependencies in pull requests or not ?

OVERLORD added the 🔧 Maintenance label 2026-02-05 00:24:44 +03:00

OVERLORD closed this issue

2026-02-05 00:24:47 +03:00

OVERLORD commented

2026-02-05 00:24:51 +03:00

@ssddanbrown commented on GitHub (Jul 15, 2019):

Thanks for the offer @imanghafoori1 but I'd prefer not to increase the dependencies without clear requirement or benefit to the project.

@ssddanbrown commented on GitHub (Jul 15, 2019): Thanks for the offer @imanghafoori1 but I'd prefer not to increase the dependencies without clear requirement or benefit to the project.

OVERLORD commented

2026-02-05 00:24:57 +03:00

@imanghafoori1 commented on GitHub (Jul 16, 2019):

Of course it has clear benefits for code quality, but it still depends on the fact that how much you want your code to be cleaned up, or you are happy with it, that it just works.

I am curently doing a full rewrite on https://github.com/thekordy/ticketit to make it fully modular.
It will be released in a few days. You may inspire from it.

@imanghafoori1 commented on GitHub (Jul 16, 2019): Of course it has clear benefits for code quality, but it still depends on the fact that how much you want your code to be cleaned up, or you are happy with it, that it just works. I am curently doing a full rewrite on https://github.com/thekordy/ticketit to make it fully modular. It will be released in a few days. You may inspire from it.

OVERLORD commented

2026-02-05 00:25:03 +03:00

@ssddanbrown commented on GitHub (Jul 17, 2019):

Yeah, that's fair but familiarity, style and opinion also factor in I think. I'll close this for now but feel free to add a comment with a link to your re-write, once done, as I'm always interested to see real-life code organisation patterns.

@ssddanbrown commented on GitHub (Jul 17, 2019): Yeah, that's fair but familiarity, style and opinion also factor in I think. I'll close this for now but feel free to add a comment with a link to your re-write, once done, as I'm always interested to see real-life code organisation patterns.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#1253