Unable to delete a page that was set as the Homepage after switching between homepage modes #1183

Closed
opened 2026-02-05 00:10:34 +03:00 by OVERLORD · 1 comment
Owner

Originally created by @nitrix on GitHub (May 14, 2019).

Describe the bug
Unable to delete a page that was set as the Homepage after switching between homepage modes.

Steps To Reproduce

  1. Go to Settings.
  2. Choose the mode "Specific Page" for your homepage and select a page of your choice.
  3. Save.
  4. Change the mode back to either "Shelves" or "Books".
  5. Save.
  6. Now go see the page you previously had selected during step 2 and attempt to delete said page.
  7. Error toast saying "Cannot delete a page while it is set as a homepage".

Expected behavior
Since the page is no longer used as Homepage, I would expect the page to be removable now.

Your Configuration:
BookStack v0.26.1

Additional context
I think this is a case of confusing UI. Notice that if the user selects again "Specific Page", they will see the pages that are marked as homepages listed and are then able to click "Reset". The problem is that switching between homepage modes doesn't do this step for you.

Actually, I think it's two fold. Either that mark should get cleared when switching modes (not ideal), or the logic that shows the error should first ensure that the site is in "Specific Page" mode prior to denying you (much better idea).

Originally created by @nitrix on GitHub (May 14, 2019). **Describe the bug** Unable to delete a page that was set as the Homepage after switching between homepage modes. **Steps To Reproduce** 1. Go to Settings. 2. Choose the mode "Specific Page" for your homepage and select a page of your choice. 3. Save. 4. Change the mode back to either "Shelves" or "Books". 5. Save. 6. Now go see the page you previously had selected during step 2 and attempt to delete said page. 7. Error toast saying "Cannot delete a page while it is set as a homepage". **Expected behavior** Since the page is no longer used as Homepage, I would expect the page to be removable now. **Your Configuration:** BookStack v0.26.1 **Additional context** I think this is a case of confusing UI. Notice that if the user selects again "Specific Page", they will see the pages that are marked as homepages listed and are then able to click "Reset". The problem is that switching between homepage _modes_ doesn't do this step for you. Actually, I think it's two fold. Either that mark should get cleared when switching modes (not ideal), or the logic that shows the error should first ensure that the site is in "Specific Page" mode prior to denying you (much better idea).
OVERLORD added the 🐛 Bug🏭 Back-End labels 2026-02-05 00:10:34 +03:00
Author
Owner

@ssddanbrown commented on GitHub (May 27, 2019):

Thanks for reporting @nitrix.

Fix now applied to master, ready for the next patch release. The page deletion will now not prevent deletion if the homepage type is not set to "Specific Page".

@ssddanbrown commented on GitHub (May 27, 2019): Thanks for reporting @nitrix. Fix now applied to master, ready for the next patch release. The page deletion will now not prevent deletion if the homepage type is not set to "Specific Page".
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#1183