starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-11 11:19:38 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

Application Homepage shows Books without view permission through shelves #1170

New Issue
Closed
opened 2026-02-05 00:08:40 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 00:08:40 +03:00
Owner
Copy Link

Originally created by @Bolthier on GitHub (May 7, 2019).

Describe the bug
While using Shelves as the Application Homepage the title of Books without view permission can be viewed. The Shelve page does not show these titles.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to settings and set Shelves as Application Homepage
  2. Create a book in a shelf
  3. Set custom permissions so you shouldn't be able to view the book
  4. Go to homepage and see the book title in list view

Expected behavior
The title shouldn't be visible like on the default Shelves page.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): BookStack v0.26.0
  • PHP Version: 7.2.10
  • Hosting Method (Nginx/Apache/Docker): Apache 2
Originally created by @Bolthier on GitHub (May 7, 2019). **Describe the bug** While using Shelves as the Application Homepage the title of Books without view permission can be viewed. The Shelve page does not show these titles. **Steps To Reproduce** Steps to reproduce the behavior: 1. Go to settings and set Shelves as Application Homepage 2. Create a book in a shelf 3. Set custom permissions so you shouldn't be able to view the book 4. Go to homepage and see the book title in list view **Expected behavior** The title shouldn't be visible like on the default Shelves page. **Your Configuration (please complete the following information):** - Exact BookStack Version (Found in settings): BookStack v0.26.0 - PHP Version: 7.2.10 - Hosting Method (Nginx/Apache/Docker): Apache 2
OVERLORD added the 🐛 Bug🚀 Priority🔒 Security labels 2026-02-05 00:08:40 +03:00
OVERLORD commented 2026-02-05 00:08:47 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (May 7, 2019):

Thanks for reporting @Bolthier, I'll look to get a fix out for this tonight if possible, otherwise tomorrow night.

@ssddanbrown commented on GitHub (May 7, 2019): Thanks for reporting @Bolthier, I'll look to get a fix out for this tonight if possible, otherwise tomorrow night.
OVERLORD commented 2026-02-05 00:08:51 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (May 8, 2019):

Fix now in master, with test to cover. Should being released tonight. Thanks again for reporting.

@ssddanbrown commented on GitHub (May 8, 2019): Fix now in master, with test to cover. Should being released tonight. Thanks again for reporting.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 🐛 Bug 🔒 Security 🚀 Priority
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#1170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?