mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Rebuild front-end translation system #1024
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Feb 4, 2019).
Originally assigned to: @ssddanbrown on GitHub.
Just putting this as a reminder to myself really.
Need to cleanup front-end translation system (
/translationsendpoint).It's a badly-done system, inefficient system.
Instead only the translations used should land in the browser. Insert those via standard tags then parse out with standard JS. Translations could be defined near where but have blade stacks gather these into a common location.
@ezzra commented on GitHub (Feb 5, 2019):
I dont understand that very well, isn't that the case already? The textes are translated in backend when the html file is generated, arent they?
@ssddanbrown commented on GitHub (Feb 6, 2019):
@ezzra Yeah, This is more for translation used inside of JavaScript components which is handled on the front-end, differently to the majority of the translations which are inserted within the back-end blade files.
@ezzra commented on GitHub (Feb 6, 2019):
Ah ok, I totally missed the front-end and was confused :)