starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-25 11:19:39 +03:00
Code Issues 784 Packages Projects Releases 14 Wiki Activity

Theme System: Split & organised tests, changed module version to string

Browse Source
This commit is contained in:
Dan Brown
2026-02-01 16:27:52 +00:00
parent 4949520194
commit cd84074cdf
5 changed files with 278 additions and 258 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/Theming/ThemeModule.php
View File

@@ -9,7 +9,7 @@ class ThemeModule
protected string $name;
protected string $description;
protected string $folderName;
protected int $version;
protected string $version;
/**
* Create a ThemeModule instance from JSON data.
@@ -26,10 +26,14 @@ class ThemeModule
throw new ThemeException("Module in folder \"{$folderName}\" is missing a valid 'description' property");
}
if (!isset($data['version']) || !is_int($data['version']) || $data['version'] < 1) {
if (!isset($data['version']) || !is_string($data['version'])) {
throw new ThemeException("Module in folder \"{$folderName}\" is missing a valid 'version' property");
}
if (!preg_match('/^v?\d+\.\d+\.\d+(-.*)?$/', $data['version'])) {
throw new ThemeException("Module in folder \"{$folderName}\" has an invalid 'version' format. Expected semantic version format like '1.0.0' or 'v1.0.0'");
}
$module = new static();
$module->name = $data['name'];
$module->description = $data['description'];