starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-07-15 21:31:36 +03:00
Code Issues 784 Packages Projects Releases 25 Wiki Activity

User MFA: Reviewed addition of reset, added tests

Browse Source 
Review of #6056
Added test coverage.
This commit is contained in:
Dan Brown
2026-05-17 13:00:38 +01:00
parent 321271e7bd
commit 39a14cff8f
7 changed files with 102 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
tests/User/UserManagementMfaTest.php Normal file
View File

@@ -0,0 +1,59 @@
<?php
namespace Tests\User;
use BookStack\Access\Mfa\MfaValue;
use BookStack\Activity\ActivityType;
use BookStack\Permissions\Permission;
use Tests\TestCase;
class UserManagementMfaTest extends TestCase
{
public function test_configured_mfa_options_visible_on_user_edit()
{
$editor = $this->users->editor();
$resp = $this->asAdmin()->get($editor->getEditUrl());
$resp->assertSeeText('0 methods configured');
MfaValue::factory()->create(['user_id' => $editor->id, 'method' => MfaValue::METHOD_BACKUP_CODES]);
$resp = $this->get($editor->getEditUrl());
$resp->assertSeeText('1 method configured');
$resp->assertDontSeeText('0 methods configured');
}
public function test_reset_mfa_flow()
{
$editor = $this->users->editor();
MfaValue::factory()->create(['user_id' => $editor->id, 'method' => MfaValue::METHOD_BACKUP_CODES]);
MfaValue::factory()->create(['user_id' => $editor->id, 'method' => MfaValue::METHOD_TOTP]);
$this->assertEquals(2, $editor->mfaValues()->count());
$resp = $this->asAdmin()->get($editor->getEditUrl());
$this->withHtml($resp)->assertElementContains('form[action$="/mfa"] button[type="submit"]', 'Reset');
$resp = $this->delete($editor->getEditUrl('/mfa'));
$resp->assertRedirect($editor->getEditUrl());
$this->assertActivityExists(ActivityType::USER_MFA_RESET);
$resp = $this->followRedirects($resp);
$resp->assertSee('Multi-factor authentication methods reset');
$this->assertEquals(0, $editor->mfaValues()->count());
}
public function test_users_manage_permission_required_for_mfa_reset()
{
$editor = $this->users->editor();
$resp = $this->actingAs($editor)->delete($editor->getEditUrl('/mfa'));
$this->assertPermissionError($resp);
$this->permissions->grantUserRolePermissions($editor, [Permission::UsersManage]);
$resp = $this->delete($editor->getEditUrl('/mfa'));
$this->assertNotPermissionError($resp);
$resp->assertRedirect($editor->getEditUrl());
}
}