mirror of
https://github.com/immich-app/immich.git
synced 2025-12-25 09:14:58 +03:00
* fix: Any asset update disables isFavorite action in GUI. Only owner of asset in album should see favorited image. * Fix unit tests * Fix formatting * better query, add medium test * update sql --------- Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com>
191 lines
6.1 KiB
TypeScript
191 lines
6.1 KiB
TypeScript
import { BadRequestException } from '@nestjs/common';
|
|
import { AssetVisibility } from 'src/enum';
|
|
import { TimelineService } from 'src/services/timeline.service';
|
|
import { authStub } from 'test/fixtures/auth.stub';
|
|
import { newTestService, ServiceMocks } from 'test/utils';
|
|
|
|
describe(TimelineService.name, () => {
|
|
let sut: TimelineService;
|
|
let mocks: ServiceMocks;
|
|
|
|
beforeEach(() => {
|
|
({ sut, mocks } = newTestService(TimelineService));
|
|
});
|
|
|
|
describe('getTimeBuckets', () => {
|
|
it("should return buckets if userId and albumId aren't set", async () => {
|
|
mocks.asset.getTimeBuckets.mockResolvedValue([{ timeBucket: 'bucket', count: 1 }]);
|
|
|
|
await expect(sut.getTimeBuckets(authStub.admin, {})).resolves.toEqual(
|
|
expect.arrayContaining([{ timeBucket: 'bucket', count: 1 }]),
|
|
);
|
|
expect(mocks.asset.getTimeBuckets).toHaveBeenCalledWith({
|
|
userIds: [authStub.admin.user.id],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('getTimeBucket', () => {
|
|
it('should return the assets for a album time bucket if user has album.read', async () => {
|
|
mocks.access.album.checkOwnerAccess.mockResolvedValue(new Set(['album-id']));
|
|
const json = `[{ id: ['asset-id'] }]`;
|
|
mocks.asset.getTimeBucket.mockResolvedValue({ assets: json });
|
|
|
|
await expect(sut.getTimeBucket(authStub.admin, { timeBucket: 'bucket', albumId: 'album-id' })).resolves.toEqual(
|
|
json,
|
|
);
|
|
|
|
expect(mocks.access.album.checkOwnerAccess).toHaveBeenCalledWith(authStub.admin.user.id, new Set(['album-id']));
|
|
expect(mocks.asset.getTimeBucket).toHaveBeenCalledWith(
|
|
'bucket',
|
|
{
|
|
timeBucket: 'bucket',
|
|
albumId: 'album-id',
|
|
},
|
|
authStub.admin,
|
|
);
|
|
});
|
|
|
|
it('should return the assets for a archive time bucket if user has archive.read', async () => {
|
|
const json = `[{ id: ['asset-id'] }]`;
|
|
mocks.asset.getTimeBucket.mockResolvedValue({ assets: json });
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
visibility: AssetVisibility.Archive,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).resolves.toEqual(json);
|
|
expect(mocks.asset.getTimeBucket).toHaveBeenCalledWith(
|
|
'bucket',
|
|
expect.objectContaining({
|
|
timeBucket: 'bucket',
|
|
visibility: AssetVisibility.Archive,
|
|
userIds: [authStub.admin.user.id],
|
|
}),
|
|
authStub.admin,
|
|
);
|
|
});
|
|
|
|
it('should include partner shared assets', async () => {
|
|
const json = `[{ id: ['asset-id'] }]`;
|
|
mocks.asset.getTimeBucket.mockResolvedValue({ assets: json });
|
|
mocks.partner.getAll.mockResolvedValue([]);
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
visibility: AssetVisibility.Timeline,
|
|
userId: authStub.admin.user.id,
|
|
withPartners: true,
|
|
}),
|
|
).resolves.toEqual(json);
|
|
expect(mocks.asset.getTimeBucket).toHaveBeenCalledWith(
|
|
'bucket',
|
|
{
|
|
timeBucket: 'bucket',
|
|
visibility: AssetVisibility.Timeline,
|
|
withPartners: true,
|
|
userIds: [authStub.admin.user.id],
|
|
},
|
|
authStub.admin,
|
|
);
|
|
});
|
|
|
|
it('should check permissions to read tag', async () => {
|
|
const json = `[{ id: ['asset-id'] }]`;
|
|
mocks.asset.getTimeBucket.mockResolvedValue({ assets: json });
|
|
mocks.access.tag.checkOwnerAccess.mockResolvedValue(new Set(['tag-123']));
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
userId: authStub.admin.user.id,
|
|
tagId: 'tag-123',
|
|
}),
|
|
).resolves.toEqual(json);
|
|
expect(mocks.asset.getTimeBucket).toHaveBeenCalledWith(
|
|
'bucket',
|
|
{
|
|
tagId: 'tag-123',
|
|
timeBucket: 'bucket',
|
|
userIds: [authStub.admin.user.id],
|
|
},
|
|
authStub.admin,
|
|
);
|
|
});
|
|
|
|
it('should return the assets for a library time bucket if user has library.read', async () => {
|
|
const json = `[{ id: ['asset-id'] }]`;
|
|
mocks.asset.getTimeBucket.mockResolvedValue({ assets: json });
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).resolves.toEqual(json);
|
|
expect(mocks.asset.getTimeBucket).toHaveBeenCalledWith(
|
|
'bucket',
|
|
expect.objectContaining({
|
|
timeBucket: 'bucket',
|
|
userIds: [authStub.admin.user.id],
|
|
}),
|
|
authStub.admin,
|
|
);
|
|
});
|
|
|
|
it('should throw an error if withParners is true and visibility true or undefined', async () => {
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
visibility: AssetVisibility.Archive,
|
|
withPartners: true,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).rejects.toThrow(BadRequestException);
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
visibility: undefined,
|
|
withPartners: true,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).rejects.toThrow(BadRequestException);
|
|
});
|
|
|
|
it('should throw an error if withParners is true and isFavorite is either true or false', async () => {
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
isFavorite: true,
|
|
withPartners: true,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).rejects.toThrow(BadRequestException);
|
|
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
isFavorite: false,
|
|
withPartners: true,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).rejects.toThrow(BadRequestException);
|
|
});
|
|
|
|
it('should throw an error if withParners is true and isTrash is true', async () => {
|
|
await expect(
|
|
sut.getTimeBucket(authStub.admin, {
|
|
timeBucket: 'bucket',
|
|
isTrashed: true,
|
|
withPartners: true,
|
|
userId: authStub.admin.user.id,
|
|
}),
|
|
).rejects.toThrow(BadRequestException);
|
|
});
|
|
});
|
|
});
|