immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3244] fix(mobile): fix forgetting backup albums (#3108) #9903

New Issue
Closed
opened 2026-02-05 14:12:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:12:41 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/3244

State: closed
Merged: Yes

Fix/workaround for #3108. It seems the bug is caused by a weird behaviour / bug in photo_manager: Sometimes AssetPathEntity.fromId throws even when called with a valid asset id (say one returned from a previous call to PhotoManager.getAssetPathList).

This PR works around that by looking the assets up in a previously obtained map instead of calling AssetPathEntity.fromId.

How has this been tested

Manually, by deploying the patched app to my phone with flutter run and then going through the repro steps.

**Original Pull Request:** https://github.com/immich-app/immich/pull/3244 **State:** closed **Merged:** Yes --- Fix/workaround for #3108. It seems the bug is caused by a weird behaviour / bug in [photo_manager](https://pub.dev/packages/photo_manager): Sometimes `AssetPathEntity.fromId` throws even when called with a valid asset id (say one returned from a previous call to `PhotoManager.getAssetPathList`). This PR works around that by looking the assets up in a previously obtained map instead of calling `AssetPathEntity.fromId`. ### How has this been tested Manually, by deploying the patched app to my phone with `flutter run` and then going through the repro steps.
OVERLORD added the pull-request label 2026-02-05 14:12:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?