immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3138] refactor(server): modularize getFfmpegOptions #9864

New Issue
Closed
opened 2026-02-05 14:12:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:12:05 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/3138

State: closed
Merged: Yes

Description

Modularizes getFfmpegOptions into separate handlers for each codec and adds enums for several transcoding settings.

getFfmpegOptions has become too complex and monolithic to make major changes to it without either increasing its complexity further or introducing bugs. This change makes the intended behavior for each codec much more explicit, and makes adding a new codec as simple as adding a new handler without affecting existing logic.

Notably, the only major change is to the code structure. Existing behavior should be the same.

Testing

Tests are unchanged (except for the addition of an inputOptions property in TranscodeOptions) and all pass. I tried different transcoding settings and all were applied and transcoded correctly.

**Original Pull Request:** https://github.com/immich-app/immich/pull/3138 **State:** closed **Merged:** Yes --- ## Description Modularizes `getFfmpegOptions` into separate handlers for each codec and adds enums for several transcoding settings. `getFfmpegOptions` has become too complex and monolithic to make major changes to it without either increasing its complexity further or introducing bugs. This change makes the intended behavior for each codec much more explicit, and makes adding a new codec as simple as adding a new handler without affecting existing logic. Notably, the only major change is to the code structure. Existing behavior should be the same. ## Testing Tests are unchanged (except for the addition of an `inputOptions` property in `TranscodeOptions`) and all pass. I tried different transcoding settings and all were applied and transcoded correctly.
OVERLORD added the pull-request label 2026-02-05 14:12:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9864
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?