immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3109] refactor(server)!: add/remove album assets #9858

New Issue
Closed
opened 2026-02-05 14:11:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:11:58 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/immich-app/immich/pull/3109

State: closed
Merged: Yes

Breaking Change: Mobile app and server must both be up to date

If the mobile app and server are out of sync the following will no longer work:

  • Add assets to albums
  • Remove assets from albums

TODO:

  • Unit tests
  • Web testing
  • Mobile testing
  • Perf testing
  • Access testing
  • Test removing current thumbnail

Test Scenarios

  • Add own assets to album
  • Remove own assets from album
  • Add own assets to a non-owned, shared album
  • Drag and drop new assets to a non-owned, shared album (lots of notifications)
  • Remove own assets from a non-owned, shared album (new feature 🎉)
  • Remove a partner shared asset from a non-owned, shared album (via API confirmed no remove access without partner sharing and confirmed removed success with partner sharing)
  • Remove current thumbnail asset from album and verify new thumbnail is set
  • Remove last asset from album and verify album has null thumbnail

Mobile Testing

  • Add asset(s) from album viewer (owned/shared)
  • Add asset(s) from the timeline (owned/shared)
  • Add asset from the detail viewer (owned/shared)
  • Remove asset(s) from the album viewer (owned)
  • Add asset(s) from the web and check the presence on the mobile app
**Original Pull Request:** https://github.com/immich-app/immich/pull/3109 **State:** closed **Merged:** Yes --- ### Breaking Change: Mobile app and server must both be up to date If the mobile app and server are out of sync the following will no longer work: - Add assets to albums - Remove assets from albums <hr> TODO: - [x] Unit tests - [x] Web testing - [x] Mobile testing - [ ] Perf testing - [x] Access testing - [x] Test removing current thumbnail Test Scenarios - Add own assets to album - Remove own assets from album - Add own assets to a non-owned, shared album - Drag and drop new assets to a non-owned, shared album (lots of notifications) - Remove own assets from a non-owned, shared album (new feature :tada:) - Remove a partner shared asset from a non-owned, shared album (via API confirmed no remove access without partner sharing and confirmed removed success with partner sharing) - Remove current thumbnail asset from album and verify new thumbnail is set - Remove last asset from album and verify album has null thumbnail ---- Mobile Testing - Add asset(s) from album viewer (owned/shared) - Add asset(s) from the timeline (owned/shared) - Add asset from the detail viewer (owned/shared) - Remove asset(s) from the album viewer (owned) - Add asset(s) from the web and check the presence on the mobile app
OVERLORD added the pull-request label 2026-02-05 14:11:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9858
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?