immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2965] [MERGED] feat(Android): guard against missing EXIF info #9797

New Issue
Closed
opened 2026-02-05 14:10:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:10:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2965
Author: @fyfrey
Created: 6/26/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @alextran1502

Base: main ← Head: dev/android-access-media-location

📝 Commits (1)

  • 6fd60fd feat(Android): guard against missing EXIF info

📊 Changes

2 files changed (+37 additions, -16 deletions)

View changed files

📝 mobile/lib/modules/backup/services/backup.service.dart (+11 -0)
📝 mobile/lib/modules/onboarding/providers/gallery_permission.provider.dart (+26 -16)

📄 Description

Many asset backups on Android are corrupt because the app did not have permission to access media file location (GPS EXIF data). This results in checksum being different after this permission is granted leading to sync issues.

This PR adds checks to a) request the permissions and b) only backup files if permissions are granted

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2965 **Author:** [@fyfrey](https://github.com/fyfrey) **Created:** 6/26/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `dev/android-access-media-location` --- ### 📝 Commits (1) - [`6fd60fd`](https://github.com/immich-app/immich/commit/6fd60fd89448263e9d2f23fa3fe4f1d4bbd25e9f) feat(Android): guard against missing EXIF info ### 📊 Changes **2 files changed** (+37 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/backup/services/backup.service.dart` (+11 -0) 📝 `mobile/lib/modules/onboarding/providers/gallery_permission.provider.dart` (+26 -16) </details> ### 📄 Description Many asset backups on Android are corrupt because the app did not have permission to access media file location (GPS EXIF data). This results in checksum being different after this permission is granted leading to sync issues. This PR adds checks to a) request the permissions and b) only backup files if permissions are granted --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:10:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9797
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?