immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2910] [MERGED] refactor(server): access permissions #9770

New Issue
Closed
opened 2026-02-05 14:10:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:10:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2910
Author: @jrasm91
Created: 6/22/2023
Status: ✅ Merged
Merged: 6/28/2023
Merged by: @alextran1502

Base: main ← Head: refactor/access-permissions

📝 Commits (6)

  • 8a42125 refactor: access repo interface
  • cd22d41 feat: access core
  • 6177f45 fix: allow shared links to add to a shared link
  • cd46f29 chore: comment out unused code
  • 3c88e7d fix: pr feedback
  • b5b60b7 Merge branch 'main' of github.com:immich-app/immich into refactor/access-permissions

📊 Changes

11 files changed (+393 additions, -266 deletions)

View changed files

➕ server/src/domain/access/access.core.ts (+134 -0)
📝 server/src/domain/access/access.repository.ts (+14 -6)
📝 server/src/domain/access/index.ts (+1 -0)
📝 server/src/domain/album/album.service.spec.ts (+28 -18)
📝 server/src/domain/album/album.service.ts (+14 -15)
📝 server/src/domain/shared-link/shared-link.service.spec.ts (+12 -11)
📝 server/src/domain/shared-link/shared-link.service.ts (+10 -16)
📝 server/src/immich/api-v1/asset/asset.service.spec.ts (+28 -27)
📝 server/src/immich/api-v1/asset/asset.service.ts (+32 -91)
📝 server/src/infra/repositories/access.repository.ts (+99 -75)
📝 server/test/repositories/access.repository.mock.ts (+21 -7)

📄 Description

Create an AccessCore where all asset, album, etc. access checks can be consolidated. Eventually, hopefully, this logic can be enhanced with additional modifiers (additional share settings set on the user, album, asset, api key, etc.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2910 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 6/22/2023 **Status:** ✅ Merged **Merged:** 6/28/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/access-permissions` --- ### 📝 Commits (6) - [`8a42125`](https://github.com/immich-app/immich/commit/8a421253d1c22e2e1998cc49530af111b708f3a0) refactor: access repo interface - [`cd22d41`](https://github.com/immich-app/immich/commit/cd22d411b0560e83339b23a936a59868935468a2) feat: access core - [`6177f45`](https://github.com/immich-app/immich/commit/6177f4517d789c4d860f2124ec1b06ac17617738) fix: allow shared links to add to a shared link - [`cd46f29`](https://github.com/immich-app/immich/commit/cd46f298aeee3384ed263418ecbeebfa817cbe39) chore: comment out unused code - [`3c88e7d`](https://github.com/immich-app/immich/commit/3c88e7d250a4f9297e562b3b060329748bcdba15) fix: pr feedback - [`b5b60b7`](https://github.com/immich-app/immich/commit/b5b60b73538e371114ec3f09a02414a71c16153f) Merge branch 'main' of github.com:immich-app/immich into refactor/access-permissions ### 📊 Changes **11 files changed** (+393 additions, -266 deletions) <details> <summary>View changed files</summary> ➕ `server/src/domain/access/access.core.ts` (+134 -0) 📝 `server/src/domain/access/access.repository.ts` (+14 -6) 📝 `server/src/domain/access/index.ts` (+1 -0) 📝 `server/src/domain/album/album.service.spec.ts` (+28 -18) 📝 `server/src/domain/album/album.service.ts` (+14 -15) 📝 `server/src/domain/shared-link/shared-link.service.spec.ts` (+12 -11) 📝 `server/src/domain/shared-link/shared-link.service.ts` (+10 -16) 📝 `server/src/immich/api-v1/asset/asset.service.spec.ts` (+28 -27) 📝 `server/src/immich/api-v1/asset/asset.service.ts` (+32 -91) 📝 `server/src/infra/repositories/access.repository.ts` (+99 -75) 📝 `server/test/repositories/access.repository.mock.ts` (+21 -7) </details> ### 📄 Description Create an `AccessCore` where all asset, album, etc. access checks can be consolidated. Eventually, hopefully, this logic can be enhanced with additional modifiers (additional share settings set on the user, album, asset, api key, etc.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:10:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?