immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2908] [MERGED] fix(server): use exiftool decoded values and unify metadata extraction #9764

New Issue
Closed
opened 2026-02-05 14:10:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:10:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2908
Author: @uhthomas
Created: 6/22/2023
Status: ✅ Merged
Merged: 9/18/2023
Merged by: @jrasm91

Base: main ← Head: 2859

📝 Commits (4)

📊 Changes

8 files changed (+432 additions, -395 deletions)

View changed files

📝 server/package-lock.json (+342 -47)
📝 server/package.json (+2 -1)
📝 server/src/microservices/processors/metadata-extraction.processor.ts (+86 -247)
➖ server/src/microservices/utils/exif/date-time.spec.ts (+0 -36)
➖ server/src/microservices/utils/exif/date-time.ts (+0 -24)
➖ server/src/microservices/utils/exif/iso.spec.ts (+0 -24)
➖ server/src/microservices/utils/exif/iso.ts (+0 -14)
📝 web/src/lib/utils/asset-utils.ts (+2 -2)

📄 Description

There was a lot of unnecessary stuff happening which exiftool should have already taken care of. It's been replaced with the values provided by the exiftool package and the code is much cleaner as a result. Further, exiftool can be used to extract metadata from videos which greatly simplifies things.

Fixes: #2786, #2859, #2953, #1705, #3923, #3888, #3875, #3817

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2908 **Author:** [@uhthomas](https://github.com/uhthomas) **Created:** 6/22/2023 **Status:** ✅ Merged **Merged:** 9/18/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `2859` --- ### 📝 Commits (4) - [`71f2bb1`](https://github.com/immich-app/immich/commit/71f2bb1dbed832297546b8352c6808670045d4e5) refactor(server): metadata extraction - [`6b7fb40`](https://github.com/immich-app/immich/commit/6b7fb40612e802c6b1062e8e566e81a87a1c8153) chore: upgrade exiftool - [`7755be1`](https://github.com/immich-app/immich/commit/7755be17176eccb9e657a4fb2cfd684141d3e18e) chore: remove log - [`c54a8ce`](https://github.com/immich-app/immich/commit/c54a8cecae5ee722b844017dd761d5f2fd273794) fix: other rotation cases ### 📊 Changes **8 files changed** (+432 additions, -395 deletions) <details> <summary>View changed files</summary> 📝 `server/package-lock.json` (+342 -47) 📝 `server/package.json` (+2 -1) 📝 `server/src/microservices/processors/metadata-extraction.processor.ts` (+86 -247) ➖ `server/src/microservices/utils/exif/date-time.spec.ts` (+0 -36) ➖ `server/src/microservices/utils/exif/date-time.ts` (+0 -24) ➖ `server/src/microservices/utils/exif/iso.spec.ts` (+0 -24) ➖ `server/src/microservices/utils/exif/iso.ts` (+0 -14) 📝 `web/src/lib/utils/asset-utils.ts` (+2 -2) </details> ### 📄 Description There was a lot of unnecessary stuff happening which exiftool should have already taken care of. It's been replaced with the values provided by the exiftool package and the code is much cleaner as a result. Further, exiftool can be used to extract metadata from videos which greatly simplifies things. Fixes: #2786, #2859, #2953, #1705, #3923, #3888, #3875, #3817 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:10:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?