immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2897] [MERGED] fix(web): keep video volume #9761

New Issue
Closed
opened 2026-02-05 14:10:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:10:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2897
Author: @faupau03
Created: 6/21/2023
Status: ✅ Merged
Merged: 6/21/2023
Merged by: @alextran1502

Base: main ← Head: fix-web-keep-video-volume

📝 Commits (2)

  • d5781ac save video volume in asset-interaction.store.ts
  • 8a971f0 move video-viewer-volume to preferences store

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 web/src/lib/components/asset-viewer/video-viewer.svelte (+2 -0)
📝 web/src/lib/stores/preferences.store.ts (+2 -0)

📄 Description

save video volume in asset-interaction.store.ts, fixes #2885
google saves the video volume in localstorage, which i think would be the better implementation?

yt-player-volume:"{"data":"{\"volume\":37,\"muted\":false}","expiration":1689945428802,"creation":1687353428802}"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2897 **Author:** [@faupau03](https://github.com/faupau03) **Created:** 6/21/2023 **Status:** ✅ Merged **Merged:** 6/21/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix-web-keep-video-volume` --- ### 📝 Commits (2) - [`d5781ac`](https://github.com/immich-app/immich/commit/d5781acbf8720f144ee9ced59da3d525203eb056) save video volume in asset-interaction.store.ts - [`8a971f0`](https://github.com/immich-app/immich/commit/8a971f024cb0833655b01316887dbc9e5d893621) move video-viewer-volume to preferences store ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/asset-viewer/video-viewer.svelte` (+2 -0) 📝 `web/src/lib/stores/preferences.store.ts` (+2 -0) </details> ### 📄 Description save video volume in asset-interaction.store.ts, fixes #2885 google saves the video volume in localstorage, which i think would be the better implementation? `yt-player-volume:"{"data":"{\"volume\":37,\"muted\":false}","expiration":1689945428802,"creation":1687353428802}"` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:10:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?