immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2776] [MERGED] refactor(server): access checks #9700

New Issue
Closed
opened 2026-02-05 14:09:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:09:18 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2776
Author: @jrasm91
Created: 6/16/2023
Status: ✅ Merged
Merged: 6/16/2023
Merged by: @alextran1502

Base: main ← Head: refactor/access-checks

📝 Commits (2)

  • 1d765e2 refactor(server): access checks
  • c51c091 chore: simply asset module

📊 Changes

11 files changed (+132 additions, -99 deletions)

View changed files

📝 server/src/domain/access/access.repository.ts (+2 -0)
📝 server/src/immich/api-v1/album/album-repository.ts (+1 -23)
📝 server/src/immich/api-v1/album/album.module.ts (+1 -7)
📝 server/src/immich/api-v1/album/album.service.spec.ts (+7 -9)
📝 server/src/immich/api-v1/asset/asset-repository.ts (+0 -10)
📝 server/src/immich/api-v1/asset/asset.module.ts (+1 -9)
📝 server/src/immich/api-v1/asset/asset.service.spec.ts (+64 -16)
📝 server/src/immich/api-v1/asset/asset.service.ts (+19 -20)
📝 server/src/infra/repositories/access.repository.ts (+33 -1)
📝 server/src/infra/repositories/album.repository.ts (+2 -4)
📝 server/test/repositories/access.repository.mock.ts (+2 -0)

📄 Description

Move a few more access check to access.repository.ts. As a consequence of this, album.repository.ts is no longer used in the asset service 🎉

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2776 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/16/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/access-checks` --- ### 📝 Commits (2) - [`1d765e2`](https://github.com/immich-app/immich/commit/1d765e206cd082bca5a1ec1d71414d89b862462a) refactor(server): access checks - [`c51c091`](https://github.com/immich-app/immich/commit/c51c09198ebf87ffafda0487c92c48447f139e75) chore: simply asset module ### 📊 Changes **11 files changed** (+132 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/access/access.repository.ts` (+2 -0) 📝 `server/src/immich/api-v1/album/album-repository.ts` (+1 -23) 📝 `server/src/immich/api-v1/album/album.module.ts` (+1 -7) 📝 `server/src/immich/api-v1/album/album.service.spec.ts` (+7 -9) 📝 `server/src/immich/api-v1/asset/asset-repository.ts` (+0 -10) 📝 `server/src/immich/api-v1/asset/asset.module.ts` (+1 -9) 📝 `server/src/immich/api-v1/asset/asset.service.spec.ts` (+64 -16) 📝 `server/src/immich/api-v1/asset/asset.service.ts` (+19 -20) 📝 `server/src/infra/repositories/access.repository.ts` (+33 -1) 📝 `server/src/infra/repositories/album.repository.ts` (+2 -4) 📝 `server/test/repositories/access.repository.mock.ts` (+2 -0) </details> ### 📄 Description Move a few more access check to `access.repository.ts`. As a consequence of this, `album.repository.ts` is no longer used in the asset service :tada: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:09:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9700
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?