immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2643] [MERGED] fix(web): use id instead of assetId #9644

New Issue
Closed
opened 2026-02-05 14:08:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:08:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2643
Author: @michelheusschen
Created: 6/2/2023
Status: ✅ Merged
Merged: 6/2/2023
Merged by: @alextran1502

Base: main ← Head: fix/asset-id-validation

📝 Commits (1)

  • a3e14de fix(web): use id instead of assetId

📊 Changes

2 files changed (+13 additions, -12 deletions)

View changed files

📝 web/src/lib/stores/asset-interaction.store.ts (+1 -1)
📝 web/src/routes/(user)/share/[key]/photos/[assetId]/+page.server.ts (+12 -11)

📄 Description

#2641 changed assetId to id but some places on web didn't get changed, leading to an error when making API calls. Also fixed invalid types in +page.server.ts.

These type of errors should get caught automatically, I'll create a separate PR to add that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2643 **Author:** [@michelheusschen](https://github.com/michelheusschen) **Created:** 6/2/2023 **Status:** ✅ Merged **Merged:** 6/2/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/asset-id-validation` --- ### 📝 Commits (1) - [`a3e14de`](https://github.com/immich-app/immich/commit/a3e14de102273e39ad94cc09f5188cc83af5454d) fix(web): use id instead of assetId ### 📊 Changes **2 files changed** (+13 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/stores/asset-interaction.store.ts` (+1 -1) 📝 `web/src/routes/(user)/share/[key]/photos/[assetId]/+page.server.ts` (+12 -11) </details> ### 📄 Description #2641 changed `assetId` to `id` but some places on web didn't get changed, leading to an error when making API calls. Also fixed invalid types in `+page.server.ts`. These type of errors should get caught automatically, I'll create a separate PR to add that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:08:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9644
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?