immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #2397] [MERGED] fix(web/mobile) Use Heart Icon & small icon changes #9525

New Issue
Closed
opened 2026-02-05 14:06:19 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:06:19 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/2397
Author: @SteffenAuer
Created: 5/8/2023
Status: ✅ Merged
Merged: 5/8/2023
Merged by: @alextran1502

Base: main ← Head: use-heart-icon-for-favorites

📝 Commits (4)

  • 5e0f16c use heart instead of star for favorites
  • 87e0163 use "multiple" icon version and fill/outline depending on selected status
  • 56a5841 use photo library icons in mobile
  • 6e0a906 fix prettier

📊 Changes

12 files changed (+34 additions, -27 deletions)

View changed files

📝 mobile/lib/modules/album/ui/album_viewer_thumbnail.dart (+1 -1)
📝 mobile/lib/modules/album/views/library_page.dart (+1 -1)
📝 mobile/lib/modules/asset_viewer/ui/top_control_app_bar.dart (+1 -1)
📝 mobile/lib/modules/home/ui/asset_grid/thumbnail_image.dart (+1 -1)
📝 mobile/lib/modules/home/ui/control_bottom_app_bar.dart (+1 -1)
📝 mobile/lib/modules/search/views/search_page.dart (+1 -1)
📝 mobile/lib/shared/views/tab_controller_page.dart (+4 -4)
📝 web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte (+3 -3)
📝 web/src/lib/components/assets/thumbnail/thumbnail.svelte (+2 -2)
📝 web/src/lib/components/shared-components/side-bar/side-bar.svelte (+15 -8)
📝 web/src/routes/(user)/explore/+page.svelte (+2 -2)
📝 web/src/routes/(user)/favorites/+page.svelte (+2 -2)

📄 Description

Description

First of all, thanks for this wonderful app! I have not been using it long (about 1 week) but it was a pleasure setting it up and getting it running. Same for the dev environment 💙

This is my first time working with Dart/Flutter/Svelte soo please let me know if there is something fundamentally wrong ☺️.

This PR:

  • uses the heart icons instead of the star icon for favorites (I hope I didn't miss an occurrence). I think this is more widely used and feels more natural to me
  • uses the "multiple" icon version of some icons and fill/outline depending on selected status (in the sidebar only)
  • uses the photo library icons on mobile instead of the photo icon

All of these changes are documented below in the screenshots.

Screenshots (if appropriate):

image image
image image image image image image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/2397 **Author:** [@SteffenAuer](https://github.com/SteffenAuer) **Created:** 5/8/2023 **Status:** ✅ Merged **Merged:** 5/8/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `use-heart-icon-for-favorites` --- ### 📝 Commits (4) - [`5e0f16c`](https://github.com/immich-app/immich/commit/5e0f16c80a5c02b4a1723dda1a45e79b2ce15e8b) use heart instead of star for favorites - [`87e0163`](https://github.com/immich-app/immich/commit/87e01635fd0a4d4b78450569e411b6fb3706d03b) use "multiple" icon version and fill/outline depending on selected status - [`56a5841`](https://github.com/immich-app/immich/commit/56a5841a0a544939ca9bd49e451dea33c5016dc7) use photo library icons in mobile - [`6e0a906`](https://github.com/immich-app/immich/commit/6e0a9068e52448bc431153449113b3f43e0b8184) fix prettier ### 📊 Changes **12 files changed** (+34 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/album/ui/album_viewer_thumbnail.dart` (+1 -1) 📝 `mobile/lib/modules/album/views/library_page.dart` (+1 -1) 📝 `mobile/lib/modules/asset_viewer/ui/top_control_app_bar.dart` (+1 -1) 📝 `mobile/lib/modules/home/ui/asset_grid/thumbnail_image.dart` (+1 -1) 📝 `mobile/lib/modules/home/ui/control_bottom_app_bar.dart` (+1 -1) 📝 `mobile/lib/modules/search/views/search_page.dart` (+1 -1) 📝 `mobile/lib/shared/views/tab_controller_page.dart` (+4 -4) 📝 `web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte` (+3 -3) 📝 `web/src/lib/components/assets/thumbnail/thumbnail.svelte` (+2 -2) 📝 `web/src/lib/components/shared-components/side-bar/side-bar.svelte` (+15 -8) 📝 `web/src/routes/(user)/explore/+page.svelte` (+2 -2) 📝 `web/src/routes/(user)/favorites/+page.svelte` (+2 -2) </details> ### 📄 Description ## Description <!--- Describe your changes in detail --> <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> First of all, thanks for this wonderful app! I have not been using it long (about 1 week) but it was a pleasure setting it up and getting it running. Same for the dev environment 💙 This is my first time working with Dart/Flutter/Svelte soo please let me know if there is something fundamentally wrong ☺️. This PR: - uses the heart icons instead of the star icon for favorites (I hope I didn't miss an occurrence). I think this is more widely used and feels more natural to me - uses the "multiple" icon version of some icons and fill/outline depending on selected status (in the sidebar only) - uses the photo library icons on mobile instead of the photo icon All of these changes are documented below in the screenshots. ## Screenshots (if appropriate): <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901938-33821661-d909-47cf-be3b-b952751bd190.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901948-a89a799c-92df-4444-a768-e4a4e9eb9710.png"> <img width="203" alt="image" src="https://user-images.githubusercontent.com/60623116/236901865-105a20f6-af27-4e64-9072-130801f56d4c.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901950-2f56f447-6253-490b-8bb3-c7463477e177.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901923-760126b1-dfb8-453b-a348-def0f6dc0df6.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901927-a31030db-040d-4ee8-8da4-dbebf125f42c.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236901931-abe2f2b4-fcf9-4354-9f59-cc7beb410d9e.png"> <img width="250" alt="image" src="https://user-images.githubusercontent.com/60623116/236907324-e7332ecb-47dc-4b3f-934f-cd74f8e89bba.png"> ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:06:19 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#9525
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?